397561 - "ASSERTION: An XBL file is malformed. Did you forget the XBL namespace on the bindings tag"

Status: RESOLVED FIXED

(Core :: XBL, defect, P4)

Description

[Jesse Ruderman]

Attachment: testcase

This testcase triggers an assertion.  I think the assertion is just bogus.

###!!! ASSERTION: An XBL file is malformed.  Did you forget the XBL namespace on the bindings tag?: 'Error', file /Users/jruderman/trunk/mozilla/content/xbl/src/nsXBLService.cpp, line 404

It also triggers a gigantic leak, but I think that's covered by bug 324465 and bug 394052.

I've also seen the assertion (and leak) happen in cases where afaik the XBL isn't actually malformed, but I can't reproduce that reliably, and it's probably a separate issue from both "the assertion shouldn't be an assertion" and the leak.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I believe this assertion was added (as were many other such assertions) back when it was important to debug issues with chrome XBL.  We may want to make the assert only happen for chrome bindings or something.

Comment 2

[Surya Ismail]

Attachment: Assert if chrome, JS console error otherwise

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 323031 [details] [diff] [review]
Assert if chrome, JS console error otherwise

Please make the ReportToConsole happen for chrome too.  Other than that, looks ok.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: change assertion to warning

Here's a patch to change the assertion to a warning; it should never have been an assertion at all.  I want this in because this assertion happens randomly on some crashtests, and I'd like to fix random assertion counts ASAP.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And I can merge the other patch on top of this one too.

(I found this bug after writing the patch.)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Other patch merged on top of above:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/1c5c2b4daaf8/xbl-malformed-assert-2

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 443499 [details] [diff] [review]
change assertion to warning

r=bzbarsky (on the merged patch too).

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/c1b186e232ac
http://hg.mozilla.org/mozilla-central/rev/f14bbcd528b4