Closed Bug 397804 Opened 17 years ago Closed 17 years ago

pages loading feeds as content can trigger a leak

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

References

(
URL
)

Details

(Keywords: memory-leak)

Attachments

(2 files, 1 obsolete file)

cycle collect the SAX parser and nsParser
9.64 KB, patch
jst
: review+
sicking
: superreview+
sicking
: approval1.9+
Details | Diff | Splinter Review
use the short macro in nsParser
1.54 KB, patch
sicking
: review+
sicking
: superreview+
sicking
: approval1.9+
Details | Diff | Splinter Review 
This looks like it's actually the FeedConverter that leaks when something is really bogus. There's a bug in the toolkit parser that causes it to send things twice, but we shouldn't leak no matter what.
doesn't fix the leak yet, but probably necessary to do so
Is this related to bug 397206?
So far it looks like something different.
This makes sense. FeedConverter.js has a reference to the nsParser (as an nsIStreamListener).
Attachment #282587 - Attachment is obsolete: true
Attachment #282616 - Flags: review?(jst)
Attachment #282616 - Flags: review?(jst) → review+
Attachment #282616 - Flags: superreview?(peterv)
Attachment #282616 - Flags: superreview?(peterv) → superreview+
Though there are macros that implement all the CC stuff in a single macro when all the members are nsCOMPtrs, I can never remember the name though.
Attachment #282616 - Flags: approval1.9?
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Keywords: mlk

        Attachment #282765 -
        Flags: superreview?(jonas)

        Attachment #282765 -
        Flags: review?(jonas)

        Attachment #282765 -
        Flags: superreview?(jonas)

        Attachment #282765 -
        Flags: superreview+

        Attachment #282765 -
        Flags: review?(jonas)

        Attachment #282765 -
        Flags: review+

        Attachment #282765 -
        Flags: approval1.9+

    
  
Flags: in-testsuite?

    
    

    
  
Comment on attachment 282765 [details] [diff] [review]
use the short macro in nsParser

Landed this fixup.

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: