pages loading feeds as content can trigger a leak

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sayrer, Assigned: sayrer)

Tracking

({memory-leak})

unspecified
x86
Mac OS X
memory-leak
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
This looks like it's actually the FeedConverter that leaks when something is really bogus. There's a bug in the toolkit parser that causes it to send things twice, but we shouldn't leak no matter what.
(Assignee)

Comment 1

11 years ago
Created attachment 282587 [details] [diff] [review]
fix parser bug and cycle collect SAX

doesn't fix the leak yet, but probably necessary to do so

Comment 2

11 years ago
Is this related to bug 397206?
(Assignee)

Comment 3

11 years ago
So far it looks like something different.
(Assignee)

Comment 4

11 years ago
Created attachment 282616 [details] [diff] [review]
cycle collect the SAX parser and nsParser

This makes sense. FeedConverter.js has a reference to the nsParser (as an nsIStreamListener).
Attachment #282587 - Attachment is obsolete: true
Attachment #282616 - Flags: review?(jst)

Updated

11 years ago
Attachment #282616 - Flags: review?(jst) → review+
(Assignee)

Updated

11 years ago
Attachment #282616 - Flags: superreview?(peterv)
Attachment #282616 - Flags: superreview?(peterv) → superreview+
Though there are macros that implement all the CC stuff in a single macro when all the members are nsCOMPtrs, I can never remember the name though.
(Assignee)

Updated

11 years ago
Attachment #282616 - Flags: approval1.9?
Attachment #282616 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Keywords: mlk
(Assignee)

Comment 6

11 years ago
Created attachment 282765 [details] [diff] [review]
use the short macro in nsParser
Attachment #282765 - Flags: superreview?(jonas)
Attachment #282765 - Flags: review?(jonas)
Attachment #282765 - Flags: superreview?(jonas)
Attachment #282765 - Flags: superreview+
Attachment #282765 - Flags: review?(jonas)
Attachment #282765 - Flags: review+
Attachment #282765 - Flags: approval1.9+

Updated

11 years ago
Flags: in-testsuite?
(Assignee)

Comment 7

11 years ago
Comment on attachment 282765 [details] [diff] [review]
use the short macro in nsParser

Landed this fixup.
You need to log in before you can comment on or make changes to this bug.