397838 - Tag button shrinks in its disabled state

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[u88484]

Attachment: Screenshot

Click on inbox than an empty folder or a folder without a message selected...do this back and forth and you'll see the tag button "shrink" in size.

The drop down arrow moves to the left by 1 pixel
The tag icon and text move to the right by 2 pixels

Comment 1

[u88484]

Same with large or small icons

Comment 2

[Scott MacGregor]

I can't actually see this when i try it, although Kurt's close up of our toolbar button shows that the difference is there. In order to fix this, someone might need to make a new primarytoolbar image that has the fix.

Comment 3

[Phil Ringnalda (:philor)]

The image and the CSS at least look offhand to be right, which makes me wonder if it's CSS for enabled vs. disabled for the dropmarker.

Is this a regression, or has it been doing this since there's been a tag button?

Comment 4

[Scott MacGregor]

Phil, it looks like the spacing on the button isn't the same between the two images (the extra space  to the right of the disabled arrow marker). Although your right the buttons look to be the same width which is all that really matters when you are talking about buttons shrinking...good catch.

Comment 5

[u88484]

I'm not sure if its a regression...somehow it caught my eye while switching between folders.

Comment 6

[Wayne Mery (:wsmwk)]

Attachment: Thunderbird dropmarker margin change

regarding comment 3, it's related to the dropmarker afaict.  

In the screen shot you can see this also happens with "File selected message" dropmarker in the menu bar.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

If this was a problem on linux/gnome, I think bug 416868 fixed it.  I do not see the problem with a 3.0a1pre trunk build with GTK2.

Comment 8

[Phil Ringnalda (:philor)]

Can't remember, but it certainly seems to be Windows-only now.

Comment 9

[Phil Ringnalda (:philor)]

Andreas: now that I refound this bug, I can't find the bug that's trying to turn into a duplicate of it, but - the problem is that in http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/messenger.css#92 we set 3px of padding-start to get some space between the button and the dropmarker, but http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/winstripe/global/dropmarker.css#35, filled with its own self-importance, decides that it's !important that it be dropped down to 1px. That seems buggy, but we're not going to get that fixed in 1.9.1, so we'll just have to convince the parser that we're even more !important than that.

Comment 10

[Phil Ringnalda (:philor)]

Attachment: Fix

Sure, I always say "no, using !important should be the last desperate refuge of a cornered hacker with no other way out," but then, I'm a cornered hacker with no other way, and it's my last desperate refuge :)

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 404570 [details] [diff] [review]
Fix

Sure, r=mkmelin

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 404570 [details] [diff] [review]
Fix

Trivial CSS fix for a now more obvious problem, with the Tag button sitting out in space all alone.

Comment 13

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/82a189244d8c