Sync snooze default preference value between Sunbird and Lightning

VERIFIED FIXED in 0.9

Status

Calendar
Preferences
--
enhancement
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: dbo, Assigned: martinschroeder)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Why is Sunbird's (default) default snooze pref 60 minutes and lightning's 5
minutes?
Why is the default snooze pref to be changed via "General" options pane
instead of the "Alarms" pane?
(In reply to comment #0)
> Why is Sunbird's (default) default snooze pref 60 minutes
> and lightning's 5 minutes?

A default preference file was added to Lightning two years ago and nobody cared about the difference. After all the user can set the value as wanted. It should be no problem to unify this. What would be a good default? 5 Minutes? 15 Minutes.

> Why is the default snooze pref to be changed via "General"
> options pane instead of the "Alarms" pane?

It was there since the old Mozilla Calendar extension times and nobody cared to move it away. In addition there is currently no space left on the Alarm tab for this item.

Comment 2

11 years ago
Although I'm using 60 minutes as default, I think 15 should be fine for most of the users.

Comment 3

10 years ago
Is this needed or even used with the new alarm dialog introcuced with bug 341576?

Otherwise we should change this or file a new bug to 'Remove obsolete preference calendar.alarms.defaultsnoozelength'.
The calendar.alarms.defaultsnoozelength preference is still used in the new alarm dialog. It's the default value for the edit field in the snooze popup menu and it's used to snooze the events if you just escape the dialog.
(Assignee)

Comment 5

10 years ago
Daniel, what should be our default snooze length in both products? 5, 15, 60 minutes?
Assignee: nobody → mschroeder
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 6

10 years ago
Too long snooze values don't make too much sense to me for pending alarms. I prefer 5 minutes.
(Assignee)

Comment 7

10 years ago
Created attachment 319351 [details] [diff] [review]
[checked in] Patch v1 (change default snooze pref)
Attachment #319351 - Flags: review?(philipp)
(Assignee)

Comment 8

10 years ago
(In reply to comment #0)
> Why is the default snooze pref to be changed via "General" options pane
> instead of the "Alarms" pane?

I don't see any space left on the "Alarms" options pane in Lightning. ;) Any ideas?

Btw a dropdown solution with on/off like for the default alarm setting doesn't make sense to me. Also the secondary settings for the alarms before events and tasks should depend on the enabled/disabled state of the first preference.
to join the OT discussion: I would prefer something space saving like
  [ ] default alarm for new events [___] minutes
  [X] default alarm for new tasks  [_15] minutes

Problem is that current preference is stored as integer and can't be mapped easily to a checkbox. Either we need to manually map it or use a new preference. The former results in rather ugly code, the latter in users wondering why their settings were reset.

But I'd guess this should be a new bug.
Comment on attachment 319351 [details] [diff] [review]
[checked in] Patch v1 (change default snooze pref)

r=philipp
Attachment #319351 - Flags: review?(philipp) → review+
(Reporter)

Comment 11

10 years ago
(In reply to comment #8)
> I don't see any space left on the "Alarms" options pane in Lightning. ;) Any
> ideas?
Why not another line under "Alarm Defaults"?
On Windows the Thunderbird preference dialog is fixed size. Currently the alarm and view tab are already partly off screen (bug 385249). There is no space to add another line to this tabs.
(Assignee)

Comment 13

10 years ago
Comment on attachment 319351 [details] [diff] [review]
[checked in] Patch v1 (change default snooze pref)

Checked in on HEAD and MOZILLA_1_8_BRANCH
Attachment #319351 - Attachment description: Patch v1 (change default snooze pref) → [checked in] Patch v1 (change default snooze pref)
(Assignee)

Comment 14

10 years ago
I resolve this bug as FIXED, and have already filed a follow-up bug (bug 432675) for the adjustments to the alarm options pane.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Summary: Clarify preferences: snooze default → Sync snooze default preference value between Sunbird and Lightning
Target Milestone: --- → 0.9

Comment 15

10 years ago
Checked in lightning 2008070219 and sunbird 20080702 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.