398082 - Wrong translation for new event dialog reminder and other translation issues

Status: VERIFIED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Omar Bajraszewski]

With Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.8pre) Gecko/20070930 Sunbird/0.7

When you open new event dialog with default alarm set- 3 days before the event you can notice the following wrong translate:
'3 days before the event starts' is translated to '3 dni przed wydarzenie zaczyna się'

It should be:
3 dni przed wydarzeniem

Also open custom reminder and take a look at 'reminder':
In English version- 3 days before the event starts/the event ends
In Polish version- 3 dni przed wydarzenie kończy się/wydarzenie zaczyna się
It should be- przed końcem/początkiem wydarzenia i po zakończeniu/rozpoczęciu wydarzenia

Comment 1

[Omar Bajraszewski]

Second translate error:
Enable timezone for new event dialog. You will see not translated timezone Europe/Warsaw

Comment 2

[Marek Stępień [:marcoos, inactive]]

Calendar, so... -> Hubert

Comment 3

[Martin Schröder [:mschroeder]]

(In reply to comment #1)
> Second translate error:
> Enable timezone for new event dialog. You will see not translated timezone
> Europe/Warsaw
> 

There is no translation of the timezone in the event/task dialog (bug 393360) afaik.

Comment 4

[Omar Bajraszewski]

Also repeat>custom:

Powtarzaj>co rok>co pierwszy poniedziałek 'z' luty/marzec/itd.
IMO sounds better: 'z miesiąca' luty/marzec/itd.

Comment 5

[Omar Bajraszewski]

(In reply to comment #4)
> IMO sounds better: 'z miesiąca' luty/marzec/itd.
or even better 'w miesiącu'

Comment 6

[Hubert Gajewski]

Strange... All these strings regard WCAP but they are visible when I try to create a new event on non-WCAP calendar. Martin, can you tell me why?

http://mxr.mozilla.org/l10n/source/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.dtd#266
http://mxr.mozilla.org/l10n/source/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.properties#112

Comment 7

[Omar Bajraszewski]

(In reply to comment #6)
> Strange... All these strings regard WCAP but they are visible when I try to
> create a new event on non-WCAP calendar. 

Prototype is now enabled for non-WCAP calendar

Comment 8

[Hubert Gajewski]

(In reply to comment #7)
> (In reply to comment #6)
> > Strange... All these strings regard WCAP but they are visible when I try to
> > create a new event on non-WCAP calendar. 
> 
> Prototype is now enabled for non-WCAP calendar

I asked about it because in my opinion sun-calendar files are still prototypes and they are not ready to be the main part of Sunbird. For me, these files are difficult for localization to Polish, because:
- there are no different entities for single form and plural form in these files
- some entities are used in many different places

1. I know that when we have not plural form for (an example) word: "week" - we can create something like this:

<!ENTITY repeat.units.weeks.both "Week(s)" >

It is easy in English language :) But Polish language is more complicated:

1 week         -> 1 tydzień
2,3,4 weeks    -> 2,3,4 tygodnie
5-21 weeks     -> 5-21 tygodni
22,23,24 weeks -> 22,23,24 tygodnie
25-31 weeks    -> 25-31 tygodni
32,33,34 weeks -> 32,33,34 tygodnie
etc...

2. The same entities are used in different places - an example:

<!ENTITY event.recurrence.pattern.every.label "Every" > is used at:
a) Every 1 Day(s)
b) Every 1 Week(s)
c) Every 1 Month(s)
d) Every 1 First/Second/Third/etc... Sunday/Monday/Tuesday/etc...

In Polish it should looks like this:
a) Raz na 1 dzień
   Raz na 2 [or more] dni
b) Raz na 1 tydzień
   Raz na 2-4 tygodnie
   Raz na 5-21 tygodni
   Raz na 22-24 tygodnie
   etc...
c) Raz na 1 miesiąc
   Raz na 2-4 miesiące
   Raz na 5-21 miesięcy
   Raz na 22-24 miesiące
   etc...
d) Każdy pierwszy poniedziałek [First Monday]
   Każdy pierwszy wtorek [First Tuesday]
   Każda pierwsza środa [First Wednesday]
   Każdy pierwszy czwartek [First Thursday]
   Każdy pierwszy piątek [First Friday]
   Każda pierwsza sobota [First Saturday]
   Każda pierwsza niedziela [First Sunday]
   etc...

Sometimes I can use some synonyms, linguistic tricks to fix a problem but not always (inflection problems).

Do any other localizers have a problem with sun-calendar-event-dialog.dtd/properies files?

As I remember correctly, Marcoos had the same problem with Firefox/Thunderbird or Toolkit localization last year.

I will create a patch with some changes - it will be looks a little bit better, but not perfect.

Comment 9

[Vlado Valastiak [:wladow]]

(In reply to comment #8)
> 
> Do any other localizers have a problem with
> sun-calendar-event-dialog.dtd/properies files?
> 

Yes, this is problem in slovak language too (sk is similar to pl). I guess, this is problem at least for all Slavonic based langs like pl, sk, cs, sl etc.

Create a patch, I can give you some proposals after review (if needed) and hopefully we will find adequate solution for this.

Comment 10

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #8)
> Do any other localizers have a problem with
> sun-calendar-event-dialog.dtd/properies files?

Who doesn't? :)

However, without PROPER plurals support, these fixes don't solve the problem completely. An example in Lithuanian:

1 week         -> 1 savaitė
2-9 weeks      -> 2-9 savaitės
10-20 weeks    -> 10-20 savaičių
21 weeks       -> 21 savaitė
22-29 weeks    -> 22-29 savaitės
30 weeks       -> 30 savaičių
31 weeks       -> 31 savaitė
32-39 weeks    -> 32-39 savaitės
40 weeks       -> 40 savaičių
(cycle repeats...)

Hence, we have three different word endings even for plurals, and they can't be written in the same fashion as "week(s)".

Furthermore, some of these dialogs appear to be designed targeting only English grammar, and ignoring the fact that this may not work for other cases. What's even worse is that it's probably impossible to design them in the same fashion, but to be language-agnostic. The dialog where I set recurrence for event is a very good example of that.

Comment 11

[Simon Paquet [:sipaq]]

Guys, if issues like this arise, we need you to file a bug so that this can be fixed from our side. I wasn't aware (and that probably goes for our developers as well) that there are different forms of plural in your languages.

So please file bugs for the 

- sun-calendar-event-dialog.dtd
- sun-calendar-event-dialog.properties

files.

Comment 12

[Stefan Sitter [:ssitter]]

There already is (a very generic) Bug 359353 but I think it would be better to file a specific bug for each issue you encounter.

Comment 13

[Marek Stępień [:marcoos, inactive]]

For the plurals support throughout the Mozilla platform, see bug 177097.

Comment 14

[Hubert Gajewski]

Attachment: sun-calendar-event-dialog.dtd after changes

I cannot create a patch now. I attached sun-calendar-event-dialog.dtd file after my changes.

Maciej, can you do a patch?

Comment 15

[Maciej Chojnacki]

Attachment: Patch based on Hubert's changes

Comment 16

[Hubert Gajewski]

Comment on attachment 283532 [details] [diff] [review]
Patch based on Hubert's changes

r+

Comment 17

[Marek Stępień [:marcoos, inactive]]

Comment on attachment 283532 [details] [diff] [review]
Patch based on Hubert's changes

Checked into 1.8 branch, trunk and Sunbird 0.7 branch on behalf of Hubert.

Comment 18

[Hubert Gajewski]

Thanks Marek! Fixed.

Comment 19

[Omar Bajraszewski]

Attachment: Screenshot

Hubert, it doesn't work as expected. When you go to custom reminder the preview is incorrect, see screenshot. Is it because of you said in comment #8?

Comment 20

[Hubert Gajewski]

(In reply to comment #19)
> Created an attachment (id=283730) [details]
> Screenshot
> 
> Hubert, it doesn't work as expected. When you go to custom reminder the preview
> is incorrect, see screenshot. Is it because of you said in comment #8?

This is not a localization bug. Please create a new reminder to check it.

Comment 21

[Omar Bajraszewski]

(In reply to comment #20)
>Please create a new reminder to check it.

Ok.
Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.8pre) Gecko/20071005 Sunbird/0.7

1)Open custom reminder
2)Set:
 "Przypomnij 15 dni przed tym, kiedy wydarzenie zaczyna się" (it's ok)
3)Press OK

Result:
You can see "15 dni przed wydarzenie zaczyna się"

So I guess it won't be fixed until Bug 359353 is open...

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.8pre) Gecko/20071005 Sunbird/0.7

Comment 22

[Matthew (lilmatt) Willis]

I just pushed the SUNBIRD_0_7_RELEASE tag forward onto revision 1.1.2.19 of l10n/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.dtd

Comment 23

[Hubert Gajewski]

(In reply to comment #20)
> (In reply to comment #19)
> > Created an attachment (id=283730) [details] [details]
> > Screenshot
> > 
> > Hubert, it doesn't work as expected. When you go to custom reminder the preview
> > is incorrect, see screenshot. Is it because of you said in comment #8?
> 
> This is not a localization bug. Please create a new reminder to check it.

I'm sorry, I was wrong. I don't know why I didn't find this before:

http://mxr.mozilla.org/l10n-mozilla1.8/source/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.properties#112

Comment 24

[Hubert Gajewski]

Attachment: Patch 0.2 with some other l10n fixes

Comment 25

[Hubert Gajewski]

Attachment: sun-calendar-event-dialog.xul with patch changes

Comment 26

[Hubert Gajewski]

Attachment: Patch 0.3 with some other l10n fixes

I've removed some commas.

Comment 27

[Staś Małolepszy :stas]

>Index: l10n/pl/calendar/chrome/calendar/calendar-event-dialog.dtd
>===================================================================

>-<!ENTITY newevent.before.label              "przed" >
>-<!ENTITY newevent.after.label               "po" >
>+<!ENTITY newevent.before.label              "przed tym" >
>+<!ENTITY newevent.after.label               "po tym" >

This is generally OK, but I would propose to consider:

newevent.before.label "przed czasem"
newevent.after.label "po czasie"

and then changing 
reminder.relation.start.label to "rozpoczęcia wydarzenia"
reminder.relation.end.label to "zakończenia wydarzenia"



>Index: l10n/pl/calendar/chrome/calendar/menuOverlay.dtd
>===================================================================
 
> <!ENTITY calendar.new.journal.label              "Nowa pozycja dziennika…">
> <!ENTITY calendar.new.journal.key                "J">
>-<!ENTITY calendar.new.journal.accesskey          "z">
>+<!ENTITY calendar.new.journal.accesskey          "n">

I wasn't able to find this one in the running application.

> <!ENTITY event.delete.event                     "Usuń zaznaczone wydarzenia">
>-<!ENTITY event.delete.event.accesskey           "y">
>+<!ENTITY event.delete.event.accesskey           "U">
> 
> <!ENTITY event.delete.tasks                     "Usuń zaznaczone zadania">
> <!ENTITY event.delete.tasks.accesskey           "z">

You use "zaznaczone" (selected) + plural here (Edit menu), but "wybrane" (chosen) + singular in the context menu that pops up on a right-click.


>Index: l10n/pl/calendar/chrome/lightning/lightning.dtd
>===================================================================

> <!ENTITY lightning.toolbar.edit.calendar.label       "Edytuj wybrany kalendarz">
>-<!ENTITY lightning.toolbar.edit.calendar.accesskey   "E">
>+<!ENTITY lightning.toolbar.edit.calendar.accesskey   "U">

Is capital "U" correct here?


>Index: l10n/pl/calendar/chrome/lightning/lightning.properties
>===================================================================

> itipReplySubject=Odpowiedź na zaproszenie na wydarzenie: %1$S
>-itipReplyBodyAccept=%1$S zaakceptował(a) Twoje zaproszenie na wydarzenie.
>-itipReplyBodyDecline=%1$S odrzucił(a) Twoje zaproszenie na wydarzenie.
>+itipReplyBodyAccept=%1$S akceptuje Twoje zaproszenie na wydarzenie.
>+itipReplyBodyDecline=%1$S odrzuca Twoje zaproszenie na wydarzenie.
> itipRequestSubject=Zaproszenie na wydarzenie: %1$S
>-itipRequestBody=%1$S zaprosił(a) Cię na %2$S
>+itipRequestBody=%1$S zaprasza Cię na wydarzenie: %2$S

Capital "T" and "C" after all?

>Index: l10n/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.dtd
>===================================================================

> <!ENTITY event.reminder.label                             "Przypomnij:" >
>-<!ENTITY event.reminder.accesskey                         "m">
>+<!ENTITY event.reminder.accesskey                         "i">

Underlining "i" which is next to "j" is something I would try to avoid. How about "y"?

>-<!ENTITY reminder.relation.start.label                  "tym, kiedy wydarzenie się zaczyna">
>-<!ENTITY reminder.relation.end.label                    "tym, kiedy wydarzenie się kończy">
>+<!ENTITY reminder.relation.start.label                  "kiedy wydarzenie się zaczyna">
>+<!ENTITY reminder.relation.end.label                    "kiedy wydarzenie się kończy">

See above.


>Index: l10n/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.properties
>===================================================================

>+reminderCustomRelationStart=przed tym,
>+reminderCustomRelationEnd=po tym,
>+reminderCustomOriginBegin=kiedy wydarzenie się zaczyna
>+reminderCustomOriginEnd=kiedy wydarzenie się kończy

Again, see above.

Comment 28

[Hubert Gajewski]

(In reply to comment #27)
> >Index: l10n/pl/calendar/chrome/calendar/calendar-event-dialog.dtd
> >===================================================================
> 
> >-<!ENTITY newevent.before.label              "przed" >
> >-<!ENTITY newevent.after.label               "po" >
> >+<!ENTITY newevent.before.label              "przed tym" >
> >+<!ENTITY newevent.after.label               "po tym" >
> 
> This is generally OK, but I would propose to consider:
> 
> newevent.before.label "przed czasem"
> newevent.after.label "po czasie"
> 
> and then changing 
> reminder.relation.start.label to "rozpoczęcia wydarzenia"
> reminder.relation.end.label to "zakończenia wydarzenia"

Great idea! I've changed it.

> >Index: l10n/pl/calendar/chrome/calendar/menuOverlay.dtd
> >===================================================================
> 
> > <!ENTITY calendar.new.journal.label              "Nowa pozycja dziennika…">
> > <!ENTITY calendar.new.journal.key                "J">
> >-<!ENTITY calendar.new.journal.accesskey          "z">
> >+<!ENTITY calendar.new.journal.accesskey          "n">
> 
> I wasn't able to find this one in the running application.

These entities are temporary hidden in application:
http://mxr.mozilla.org/mozilla/source/calendar/sunbird/base/content/calendar-menubar.inc#64
 
> > <!ENTITY event.delete.event                     "Usuń zaznaczone wydarzenia">
> >-<!ENTITY event.delete.event.accesskey           "y">
> >+<!ENTITY event.delete.event.accesskey           "U">
> > 
> > <!ENTITY event.delete.tasks                     "Usuń zaznaczone zadania">
> > <!ENTITY event.delete.tasks.accesskey           "z">
> 
> You use "zaznaczone" (selected) + plural here (Edit menu), but "wybrane"
> (chosen) + singular in the context menu that pops up on a right-click.

Fixed.

> >Index: l10n/pl/calendar/chrome/lightning/lightning.dtd
> >===================================================================
> 
> > <!ENTITY lightning.toolbar.edit.calendar.label       "Edytuj wybrany kalendarz">
> >-<!ENTITY lightning.toolbar.edit.calendar.accesskey   "E">
> >+<!ENTITY lightning.toolbar.edit.calendar.accesskey   "U">
> 
> Is capital "U" correct here?

I've improved it.

> >Index: l10n/pl/calendar/chrome/lightning/lightning.properties
> >===================================================================
> 
> > itipReplySubject=Odpowiedź na zaproszenie na wydarzenie: %1$S
> >-itipReplyBodyAccept=%1$S zaakceptował(a) Twoje zaproszenie na wydarzenie.
> >-itipReplyBodyDecline=%1$S odrzucił(a) Twoje zaproszenie na wydarzenie.
> >+itipReplyBodyAccept=%1$S akceptuje Twoje zaproszenie na wydarzenie.
> >+itipReplyBodyDecline=%1$S odrzuca Twoje zaproszenie na wydarzenie.
> > itipRequestSubject=Zaproszenie na wydarzenie: %1$S
> >-itipRequestBody=%1$S zaprosił(a) Cię na %2$S
> >+itipRequestBody=%1$S zaprasza Cię na wydarzenie: %2$S
> 
> Capital "T" and "C" after all?

It is correct, because these sentences are visible in content of e-mails, not in application.

> >Index: l10n/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.dtd
> >===================================================================
> 
> > <!ENTITY event.reminder.label                             "Przypomnij:" >
> >-<!ENTITY event.reminder.accesskey                         "m">
> >+<!ENTITY event.reminder.accesskey                         "i">
> 
> Underlining "i" which is next to "j" is something I would try to avoid. How
> about "y"?

Fixed.

> >-<!ENTITY reminder.relation.start.label                  "tym, kiedy wydarzenie się zaczyna">
> >-<!ENTITY reminder.relation.end.label                    "tym, kiedy wydarzenie się kończy">
> >+<!ENTITY reminder.relation.start.label                  "kiedy wydarzenie się zaczyna">
> >+<!ENTITY reminder.relation.end.label                    "kiedy wydarzenie się kończy">
> 
> See above.

Changed.

> >Index: l10n/pl/calendar/chrome/prototypes/sun-calendar-event-dialog.properties
> >===================================================================
> 
> >+reminderCustomRelationStart=przed tym,
> >+reminderCustomRelationEnd=po tym,
> >+reminderCustomOriginBegin=kiedy wydarzenie się zaczyna
> >+reminderCustomOriginEnd=kiedy wydarzenie się kończy
> 
> Again, see above.

Changed.

Comment 29

[Hubert Gajewski]

Attachment: Patch ver. 0.4

Comment 30

[Staś Małolepszy :stas]

I'm not able to give the r+ on the attachment, so here it is:

r+ :-)

Comment 31

[Hubert Gajewski]

Fixed on trunk and MOZILLA_1_8_BRANCH.

Matthew: Can you add this patch to SUNBIRD_0_7_BRANCH and SUNBIRD_0_7_RELEASE before RC3 will be ready? 

Comment 32

[Simon Paquet [:sipaq]]

Hubert, as a localizer you don't need any special approval to add something to the 0.7 branch. Just checkout your locale from that branch and commit your changes.

Comment 33

[Hubert Gajewski]

(In reply to comment #32)
> Hubert, as a localizer you don't need any special approval to add something to
> the 0.7 branch. Just checkout your locale from that branch and commit your
> changes.

I can't:

cvs [server aborted]: "commit" requires write access to the repository

Comment 34

[Hubert Gajewski]

(In reply to comment #33)
> (In reply to comment #32)
> > Hubert, as a localizer you don't need any special approval to add something to
> > the 0.7 branch. Just checkout your locale from that branch and commit your
> > changes.
> 
> I can't:
> 
> cvs [server aborted]: "commit" requires write access to the repository

OK, I know what was wrong. I checked out this branch some days ago with anonymous user.

Comment 35

[Hubert Gajewski]

Checked in to SUNBIRD_0_7_BRANCH.

Comment 36

[Daniel Boelzle [:dbo]]

- Does this need to be checked in on HEAD and MOZILLA_1_8_BRANCH, too?
- Is this fixed w.r.t. release 0.7?

Comment 37

[Axel Hecht [:Pike]]

Stanislaw, I fixed your permissions, you should be able to plus review requests now.

Comment 38

[Hubert Gajewski]

(In reply to comment #36)
> - Does this need to be checked in on HEAD and MOZILLA_1_8_BRANCH, too?
> - Is this fixed w.r.t. release 0.7?

It was checked in to HEAD, MOZILLA_1_8_BRANCH, SUNBIRD_0_7_BRANCH.

It should be checked in to SUNBIRD_0_7_RELEASE but I don't know how to do it.



 

Comment 39

[Simon Paquet [:sipaq]]

Daniel, this was checked in on HEAD and MOZILLA_1_8_BRANCH (see comment 31). 

I'm not sure whether we still use a release tag like SUNBIRD_0_7_RELEASE or if ause just prepares the release from the current 0.7 branch. But if we do use a release tag, the tag has to be applied to those changes as well.

Comment 40

[Staś Małolepszy :stas]

Comment on attachment 285665 [details] [diff] [review]
Patch ver. 0.4

r+

Thank you Axel!

Comment 41

[Daniel Boelzle [:dbo]]

Ause will apply the RELEASE tag once we've released.

Comment 42

[Omar Bajraszewski]

Can the bug be closed?
I've just verified it with lightning 0.7 RC3 (2007102304)

Comment 43

[Omar Bajraszewski]

Verified with Lighning 0.7 and Sunbird 0.7