Closed Bug 398176 Opened 15 years ago Closed 15 years ago

Don't count invisible tabs in PageInfo screen

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: MarcoZ, Assigned: surkov)

References

Details

(Keywords: access)

Attachments

(1 file)

When opening the Page Info screen, the description for the tab elements "General" etc. contains always "1 of 5", even when only 3 or 4 tabs are visible. For example:

1. While viewing this bug, open Tools/Page Info.
2. The tabs "General", "Media", "Permissions", and "Security" are visible. The description for each of these, however, says "1 of 5", indicating that there should be more than four tabs to be navigable.

The fifth page that is marked up in browser/base/content/pageinfo/pageinfo.xul, "Feeds", which comes between "Media" and "Permissions", is not visible. Yet the description for the other four elements says "1 of 5", because in whole, there are 5 tabs marked up.

When building the Accessible Description, only the visible tabs should be counted, to give the user an accurate representation of the fact that only four tabs are currently visible.
Flags: blocking1.9?
The problem we use nsIDOMXULSelectControlItemElement (see nsXULMenuitemAccessible::GetAttributesInternal()) and we don't take into account some items can be hidden.
Attached patch patchSplinter Review
Attachment #283320 - Flags: review?(aaronleventhal)
I can confirm that this fixes the problem!
Attachment #283320 - Flags: review?(aaronleventhal)
Attachment #283320 - Flags: review+
Attachment #283320 - Flags: approval1.9?
Attachment #283320 - Flags: approval1.9? → approval1.9+
checked in
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.