398176 - Don't count invisible tabs in PageInfo screen

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

When opening the Page Info screen, the description for the tab elements "General" etc. contains always "1 of 5", even when only 3 or 4 tabs are visible. For example:

1. While viewing this bug, open Tools/Page Info.
2. The tabs "General", "Media", "Permissions", and "Security" are visible. The description for each of these, however, says "1 of 5", indicating that there should be more than four tabs to be navigable.

The fifth page that is marked up in browser/base/content/pageinfo/pageinfo.xul, "Feeds", which comes between "Media" and "Permissions", is not visible. Yet the description for the other four elements says "1 of 5", because in whole, there are 5 tabs marked up.

When building the Accessible Description, only the visible tabs should be counted, to give the user an accurate representation of the fact that only four tabs are currently visible.

Comment 1

[alexander :surkov (:asurkov)]

The problem we use nsIDOMXULSelectControlItemElement (see nsXULMenuitemAccessible::GetAttributesInternal()) and we don't take into account some items can be hidden.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[Marco Zehe (:MarcoZ)]

I can confirm that this fixes the problem!

Comment 4

[alexander :surkov (:asurkov)]

checked in