Note: There are a few cases of duplicates in user autocompletion which are being worked on.

mod_perl isn't using our precompiled CGIs

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Bugzilla-General
--
major
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

({perf})

3.0.2
Bugzilla 3.0
Bug Flags:
approval +
blocking3.1.3 +
approval3.0 +
blocking3.0.3 +

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
I was messing around with our mod_perl installation on landfill, and the perl-status page on landfill that shows information about the system.

I found something curious:

It listed some pages as having been compiled for "ModPerl::Registry" and some pages as having been compiled for "Bugzilla::ModPerl::ResponseHandler".

It turns out that since we have a custom handler, mod_perl isn't using our precompiled pages at all. They're just taking up memory and not improving performance. When I fixed the landfill mod_perl install to actually use the precompiled pages, there was a huge performance increase. This should also help a lot with the fact that our processes grow huge slowly over time. (We're compiling every page twice.)
(Assignee)

Comment 1

10 years ago
Note this also means that every single Apache process was compiling its own scripts, instead of just compiling them once and sharing them between all the children.
(Assignee)

Comment 2

10 years ago
Created attachment 283144 [details] [diff] [review]
v1

This fixes it, as tested and now running on landfill.
Attachment #283144 - Flags: review?(justdave)
Attachment #283144 - Flags: review?(LpSolit)
(Assignee)

Updated

10 years ago
Summary: mod_perl isn't using our precompiled templates → mod_perl isn't using our precompiled CGIs
(Assignee)

Updated

10 years ago
Flags: blocking3.1.3+
Flags: blocking3.0.3+

Comment 3

10 years ago
Comment on attachment 283144 [details] [diff] [review]
v1

I know nothing about mod_perl. I will let justdave review it.
Attachment #283144 - Flags: review?(LpSolit)

Comment 4

10 years ago
Does that mean you will be able to remove the use of Size::Limit module that prevents the use of mod_perl on windows ?
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
> Does that mean you will be able to remove the use of Size::Limit module that
> prevents the use of mod_perl on windows ?

  No. You could remove that now, if you want, as long as you feel OK that Apache may consume all of your memory at any particular moment.
Comment on attachment 283144 [details] [diff] [review]
v1

Serious speed improvement on a freshly-restarted apache.  It also appears to drop memory consumption by about 10M per-process, presumably because we no longer have two copies of everything loaded after it's been running for a bit.  Two thumbs up! :)
Attachment #283144 - Flags: review?(justdave) → review+
(Assignee)

Updated

10 years ago
Flags: approval3.0+
Flags: approval+
previous test was on 3.0 branch, just tested on the tip and works great there, too. :)
Blocks: 401007
(Assignee)

Comment 8

10 years ago
This was our biggest 3.0.3 blocker. I think we should release 3.0.3 as soon as possible, now. Unfortunately, with LpSolit gone for December, that might be hard. Perhaps somebody else could run QA on 3.0?

tip:

Checking in mod_perl.pl;
/cvsroot/mozilla/webtools/bugzilla/mod_perl.pl,v  <--  mod_perl.pl
new revision: 1.7; previous revision: 1.6
done

3.0 branch:

Checking in mod_perl.pl;
/cvsroot/mozilla/webtools/bugzilla/mod_perl.pl,v  <--  mod_perl.pl
new revision: 1.5.2.1; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Keywords: relnote
Whiteboard: [relnote 3.0.3]
(Assignee)

Comment 9

9 years ago
Relnoted in 3.0.3 when it was released.
Keywords: relnote
(Assignee)

Updated

9 years ago
Whiteboard: [relnote 3.0.3]
You need to log in before you can comment on or make changes to this bug.