Closed Bug 398465 Opened 18 years ago Closed 18 years ago

nsPipeOutputStream implements nsISeekableStream but doesn't QI to it.

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

Details

Attachments

(1 file)

Attached patch Fix.Splinter Review
nsPipeOutputStream has inherited from nsISeekableStream since version 1.1, but it's never been QI'able to that interface. And now, since the changes for bug 372546 went in it's nsIClassInfo interface list contains that interface, even though the class doesn't really implement it. Seems like we can just get rid of this dead code, as noone seems to have ever needed the class to inherit nsISeekableStream in the first place.
Attachment #283442 - Flags: superreview?(benjamin)
Attachment #283442 - Flags: review?(jwalden+bmo)
Attachment #283442 - Flags: superreview?(benjamin) → superreview+
Attachment #283442 - Flags: review?(jwalden+bmo) → review+
Attachment #283442 - Flags: approval1.9?
Attachment #283442 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: