398527 - Downloads should have icons on Linux

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Michael Ventnor]

Attachment: Patch

This is probably a dupe, but I searched a lot and couldn't find anything.

Our moz-icon implementation has supported filetype icons under GTK2 for a while now. We should use them where they are most prevalent, the download manager.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 283528 [details] [diff] [review]
Patch

at this point, lets just remove those ifdefs all together, and get rid of the ifdef'd code.  Preprocessing also needs to be turned off in the jar.mn.

Comment 2

[Michael Ventnor]

Attachment: Patch 2

Fine by me.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 284415 [details] [diff] [review]
Patch 2

r=sdwilsh

drivers: this is super low risk :)

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v  <--  download.xml
new revision: 1.37; previous revision: 1.36
done
Checking in toolkit/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.39; previous revision: 1.38
done

Comment 5

[pal-moz]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101312 Minefield/3.0a9pre ID:2007101312

regression.
while downloading, the file is not listed in "active" list.

Comment 6

[Shawn Wilsher :sdwilsh]

Err...whoops.  File back on the preprocessing list - r=mconnor, a=mconnor online.

Checking in toolkit/mozapps/jar.mn;
new revision: 1.40; previous revision: 1.39

Comment 7

[echoes]

i know ff uses the gtk toolkit... but this patch can't fetch icons from kde can it?  cuz i noticed i only have the generic (blank) file type icon on kde/kubuntu with all files in the dm.

Comment 8

[echoes]

ok, i take that one back, sort of...i did get an icon while saving a jpeg image.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Fedora 7 / Ubuntu 7.04: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008010404 Minefield/3.0b3pre, with the caveat that bug 410094 exists (I've seen icons not appearing until I pause or resume a download, which is weird); that bug is better-scoped, though.