Closed Bug 398724 Opened 13 years ago Closed 13 years ago

Problems with floating all-day items

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

References

Details

Attachments

(3 files)

Attached file sample
Subscribe to the attached ics file. The file defines a floating all-day recurring event with EXDATEs falling on my last entry in my week resp. month view.
=> In week view, the EXDATE on oct 06is not minded
=> In month view, the EXDATE on nov 11 is not minded
=> Opening the event dialog, the occurrences show up in *UTC*.
Blocks: 388656
Attached patch fixSplinter Review
DATE values parsed as floating (referring to bug 388656 here).
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #283714 - Flags: review?(mvl)
Attachment #283709 - Attachment mime type: text/calendar → text/plain
Comment on attachment 283714 [details] [diff] [review]
fix

r=mvl
It would rock if you would make a unit test for this
Attachment #283714 - Flags: review?(mvl) → review+
Whiteboard: [checkin-needed after 0.7]
Attached patch unit testsSplinter Review
- adds a test for this bug
- fixes unit tests (depends on bug 399864)
- makes them work on branch
Attachment #284939 - Flags: review?(mschroeder)
Comment on attachment 284939 [details] [diff] [review]
unit tests

>--- test/unit/test_datetime.js	17 Aug 2007 14:00:57 -0000	1.1.2.2
>+++ test/unit/test_datetime.js	15 Oct 2007 15:44:11 -0000
>@@ -72,9 +72,14 @@ function run_test() {
[...]
>+
>+    var event = Cc["@mozilla.org/calendar/event;1"].createInstance(Ci.calIEvent);
>+    event.icalString = "BEGIN:VEVENT\nUID:45674d53-229f-48c6-9f3b-f2b601e7ae4d\nSUMMARY:New Event\nDTSTART;VALUE=DATE:20071003\nDTEND;VALUE=DATE:20071004\nEND:VEVENT";
>+    do_check_eq(event.startDate.timezone, "floating");
>+    do_check_eq(event.endDate.timezone, "floating");
> }

You should add a comment describing for what you test and a reference to the bug.

r=mschroeder with comment added
Attachment #284939 - Flags: review?(mschroeder) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.7]
Target Milestone: --- → 0.8
Verified in nightly build 20071108, task is fixed.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.