398904 - -compose without args opens unresizable window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. %MAILNEWS_APPLICATION% /compose

Expected result: resizable compose window

Actual result: unresizable compose window

Additional information: Works fine when argument(s) are present.

This used to work in SeaMonkey before we switched to toolkit.

Comment 1

[[e-mail]]

Attachment: WindowWatcher workaround

The problem is that the WindowWatcher's OpenWindow ignores the "all" flag if you pass in a null argument. Passing an empty string works around the problem. (MsgComposeCommands.js already ignores both a null or empty string).

Comment 2

[Scott MacGregor]

Comment on attachment 283897 [details] [diff] [review]
WindowWatcher workaround

looks good Neil.

Comment 3

[Karsten Düsterloh]

Comment on attachment 283897 [details] [diff] [review]
WindowWatcher workaround

Sorry, this isn't broken under Linux. I can see the problem under Windows, though - I guess/hope, you didn't give any sufficient steps to reproduce... :(
AFAICS, resizing the window works only with the resizer in the lower right corner, but not by dragging the window edges.
Clearing the review request, since I don't have a Windows build environment to test C++ patches, sorry.

Comment 4

[Karsten Düsterloh]

Comment on attachment 283897 [details] [diff] [review]
WindowWatcher workaround

Okay, I could reproduce the bug on my Mac (while you can't drag the window edges there, without this patch the resizer in the lower right corner is missing) and that the patch here is indeed working.

Comment 5

[[e-mail]]

Fix checked in.