398962 - Add regular expression function for -moz-document rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Jason Barnabe (np)]

While domain, url, and url-prefix cover the majority of the cases you'd want to use -moz-document rules for, there are situations they can't cover adequately. For example, affecting URLs that end with a certain string ("/Special:RecentChanges") or URLs that have a changeable middle part ("http://example.com/users/1234/profile").

A regular expression function would cover these remaining cases.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(See also discussion in bug 423985, although nothing particularly relevant, I suppose.)

Comment 2

[Jason Barnabe (np)]

I will send $100 Canadian to anyone who can get this in for Firefox 3.1.

Comment 3

[Evengard]

The problem is that Firefox doesn't have a direct regexp implementation, only a JSRegExp, but I can't find any way to access it from C++...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/44bf5536e765/moz-document-regexp is a patch for this that compiles, but I haven't yet tested it at all.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 528008 [details] [diff] [review]
patch

And requesting feedback from Mounir to make sure he's ok with this method moving (unchanged) from nsHTMLInputElement to nsContentUtils.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 528008 [details] [diff] [review]
patch

>+      // copy before we know it's valid

Please document why (ExpectSymbol messing with mToken, I assume), and r=me.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/52a05ef70c66

Comment 9

[Evgueni Naverniouk]

I am SO excited to see this get implemented. It's going to bring so much extra power to userstyles! Thank you Mozilla.

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/index.php?title=en/CSS/%40-moz-document

And mentioned on Firefox 6 for developers.

Comment 11

[Mounir Lamouri (:mounir)]

Comment on attachment 528008 [details] [diff] [review]
patch

I'm happy to see this code moving to nsContentUtils.
And I'm sorry that the feedback took so long. I'm abroad for the week for a community event and it's hard to get a good internet connectivity. Though I see the patch has been landed so it didn't block anything ;)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Added one additional test:
https://hg.mozilla.org/mozilla-central/rev/278fd4966ed0

Comment 13

[Jason Barnabe (np)]

It looks to me like you need to enclose the regexp in a single or double quote (unlike url, url-prefix, and domain). Just want to make sure that that was intended.

Also, missing a "break;" here?

diff --git a/layout/style/nsCSSRules.cpp b/layout/style/nsCSSRules.cpp
--- a/layout/style/nsCSSRules.cpp
+++ b/layout/style/nsCSSRules.cpp
@@ -942,16 +942,18 @@ DocumentRule::List(FILE* out, PRInt32 aI
       case eURL:
         str.AppendLiteral("url(\"");
         break;
       case eURLPrefix:
         str.AppendLiteral("url-prefix(\"");
         break;
       case eDomain:
         str.AppendLiteral("domain(\"");
+      case eRegExp:
+        str.AppendLiteral("regexp(\"");
         break;
     }

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: add missing break

I should add a general test for rule parse+serialize idempotence that would catch this...

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, requiring quotes was intended.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 537322 [details] [diff] [review]
add missing break

r=me

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Added missing break:
https://hg.mozilla.org/mozilla-central/rev/ddc73a8ae402
and added a test that would have caught if that were in the non-DEBUG function:
https://hg.mozilla.org/mozilla-central/rev/6772105ec426