943217 - When incorrect argument is given to @-moz-document, list of valid arguments does not include regexp()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[mitchell]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131123004001

Steps to reproduce:

Writing a userstyle, I mistyped "@-moz-document regexp()" as "@-moz-document regex()", I got an error.


Actual results:

"Expected url(), url-prefix(), or domain() in @-moz-document rule but found 'regex('."


Expected results:

"Expected url(), url-prefix(), domain(), or regexp() in @-moz-document rule but found 'regex('."

Comment 1

[:Gijs (he/him)]

This message would need to be updated:

http://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/layout/css.properties#29

Comment 2

[:Gijs (he/him)]

Attachment: fix moz-document error message,

AFAICT this should be enough?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8338385 [details] [diff] [review]
fix moz-document error message,

r=dbaron.  Sorry for the delay getting to this.

Comment 4

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d265a3ab4a48

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3)
> Comment on attachment 8338385 [details] [diff] [review]
> fix moz-document error message,
> 
> r=dbaron.  Sorry for the delay getting to this.

No worries, thanks for the review!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d265a3ab4a48