398968 - editversions.cgi should use transactions for database interaction

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Emmanuel Seyman]

editversions.cgi should use bz_start_transaction/bz_commit_transaction instead of
bz_lock_tables/bz_unlock_tables.

Comment 1

[Emmanuel Seyman]

Attachment: Replace locks by transactions

Comment 2

[Max Kanat-Alexander]

Comment on attachment 283972 [details] [diff] [review]
Replace locks by transactions

That's unnecessary--I think update() already does transactions by itself. Anywhere that there's only a single update() or create() call, you don't need to use transactions or locks at all.

Comment 3

[Emmanuel Seyman]

Attachment: Remove calls to bz_lock_tables and bz_unlock_tables

Removing the calls seems to have no ill effect

Comment 4

[Max Kanat-Alexander]

Comment on attachment 283975 [details] [diff] [review]
Remove calls to bz_lock_tables and bz_unlock_tables

Oh wait, I'm a liar. This actually doesn't use transactions yet, because it's not really using Bugzilla::Object.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 283972 [details] [diff] [review]
Replace locks by transactions

This patch is correct.

Comment 6

[Frédéric Buclin]

Checking in editversions.cgi;
/cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v  <--  editversions.cgi
new revision: 1.55; previous revision: 1.54
done