398976 - The edit* cgi scripts should use transactions for database interaction

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Emmanuel Seyman]

The edit* scripts should all use bz_start_transaction/bz_commit_transaction instead of bz_lock_tables/bz_unlock_tables.

Comment 1

[Emmanuel Seyman]

Attachment: Replace locks by transactions

Comment 2

[Max Kanat-Alexander]

Comment on attachment 283981 [details] [diff] [review]
Replace locks by transactions

This looks fine, but please re-attach it as a "cvs diff" so that I can use the "File" context to verify that everything is correct.

Comment 3

[Emmanuel Seyman]

Attachment: cvs diff of the previous patch

Comment 4

[Max Kanat-Alexander]

Comment on attachment 283981 [details] [diff] [review]
Replace locks by transactions

Okay, great. I did the review using the cvs diff below, but since it wasn't a "cvs diff -u", I'm r+'ing this patch instead.

Comment 5

[Frédéric Buclin]

Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <--  editclassifications.cgi
new revision: 1.27; previous revision: 1.26
done
Checking in editcomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v  <--  editcomponents.cgi
new revision: 1.82; previous revision: 1.81
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.50; previous revision: 1.49
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.86; previous revision: 1.85
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.136; previous revision: 1.135
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.143; previous revision: 1.142
done
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.24; previous revision: 1.23
done