399073 - Remove the 'loginnetmask' parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Per our discussions at our last 2 Bugzilla meetings, this param should go away. It should always be set to 0.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 403152 [details] [diff] [review]
patch, v1

Mmm, let's store NULL instead of 0.0.0.0.

Or alternately, we could always store the IP address (which would be useful for auditing and other info) and have a restrict_to_ip column in the logincookies_table.

Comment 3

[Frédéric Buclin]

Attachment: patch, v2

Now use NULL instead of 0.0.0.0 for unrestricted IP addresses, and convert existing 0.0.0.0 IP addresses to NULL so that the corresponding cookies still work after the upgrade.

Comment 4

[Tiago Mello [:timello]]

(In reply to comment #3)
> Created an attachment (id=403207) [details]
> patch, v2
> 

This patch does not apply. We had some changes in the next line:

-                             i_am_cgi get_netaddr correct_urlbase
+                             i_am_cgi correct_urlbase
                              lsearch ssl_require_redirect use_attachbase

We need to update the patch.

Comment 5

[Frédéric Buclin]

Attachment: patch, v2.1

Bitrot due to bug 514913 fixed.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 406954 [details] [diff] [review]
patch, v2.1

Awesome. Huge cleanup. :-)

Comment 7

[Frédéric Buclin]

Checking in Bugzilla/Util.pm;                                                             
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm                       
new revision: 1.92; previous revision: 1.91                                               
done                                                                                      
Checking in Bugzilla/Auth/Login/Cookie.pm;                                                
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/Cookie.pm,v  <--  Cookie.pm        
new revision: 1.6; previous revision: 1.5                                                 
done
Checking in Bugzilla/Auth/Persist/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Persist/Cookie.pm,v  <--  Cookie.pm
new revision: 1.11; previous revision: 1.10
done
Checking in Bugzilla/Config/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Auth.pm,v  <--  Auth.pm
new revision: 1.4; previous revision: 1.3
done
Checking in Bugzilla/Config/Common.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Common.pm,v  <--  Common.pm
new revision: 1.28; previous revision: 1.27
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.124; previous revision: 1.123
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.73; previous revision: 1.72
done
Checking in docs/en/xml/troubleshooting.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/en/xml/troubleshooting.xml,v  <--  troubleshooting.xml
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/admin/params/auth.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/auth.html.tmpl,v  <--  auth.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Comment 8

[Max Kanat-Alexander]

Added to the release notes in bug 547466.