399714 - F9 hotkey not working

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Mike Cowperthwaite]

TB 3a1pre-1013, Win2K

F9 as a hotkey to show the Contacts Sidebar was implemented in bug 364229.

That key is not working, for some reason.  I've checked, and the code from that patch (attachment 249463 [details] [diff] [review]) is in place.  I've tried other accelerators from the menu and they seem to be working fine; don't know what broke this, or when.

Workaround: select from menu or toolbar instead.

Comment 1

[Magnus Melin [:mkmelin]]

Linux too.

Comment 2

[Mike Cowperthwaite]

Probably this should be another bug report, but Ctrl+Tab/Ctrl+Shift+Tab aren't working to shift focus from pane to pane in the 3-pane, either -- seen in 
3a1p-1013, Win2K.  F6/Shift+F6 work, and both pairs of keys work in the compose window.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Enable F9 shortcut

Mike, it's simple why it doesn't work. You haven't add the key to the keyset. This patch enables the F9 key to be able to show/hide the contacts sidebar.

Comment 4

[Mike Cowperthwaite]

That's weird.  I know that the keystroke worked at the time bug 364229 was fixed.  Thanks for tracking that down, Henrik.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's not correct. It never worked on trunk. You can blame Phil because he checked in the wrong content:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mail/components/compose/content&command=DIFF_FRAMESET&file=messengercompose.xul&rev2=1.102&rev1=1.101

Comment 6

[Phil Ringnalda (:philor)]

Attachment: As checked in

Comment 7

[Phil Ringnalda (:philor)]

mail/components/compose/content/messengercompose.xul 1.110

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fixed with version 3.0a1pre (2007103004) under WinXP.