399781 - Remove headings in Download Manager UI

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

As per mockup in Bug 397655.

Requesting [wanted-firefox3]

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Blank out the titles -> make them placeholder hbox areas so that we can do easy priority-queue-like insertion.

Comment 2

[Ed Lee :Mardak]

Patch depends on bug 399783 + some fixes I added myself.. :p

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 284865 [details] [diff] [review]
v1

>-var gDownloadsActiveTitle = null;
>-var gDownloadsOtherTitle  = null;
>+var gDownloadsActiveArea = null;
>+var gDownloadsDoneArea = null;
nit: please line up the =

>-  gDownloadsActiveTitle = document.getElementById("active-downloads-title");
>-  gDownloadsOtherTitle  = document.getElementById("other-downloads-title");
>+  gDownloadsActiveArea = document.getElementById("active-downloads-area");
>+  gDownloadsDoneArea = document.getElementById("done-downloads-area");
ditto

Comment 4

[Ed Lee :Mardak]

(In reply to comment #3)
> nit: please line up the =
I was thinking about lining them up.. but then a previous style guide said to not try lining up stuff with spaces because it won't work :p But that was probably in relation to using tabs for indenting.

Additionally, if I did go with gDownloadsCompletedArea, I would have had to extend all the other spaces to match up with the now-longer-one which would cause unnecessary blame loss.

Comment 5

[Shawn Wilsher :sdwilsh]

I prefer Done over Complete anyway, so we have no problem.

Comment 6

[Ed Lee :Mardak]

Attachment: for checkin

Added spaces.

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 284887 [details] [diff] [review]
for checkin

r=sdwilsh

No logic is actually changing here, so this is low risk.

Comment 8

[Ed Lee :Mardak]

Attachment: v1.1

Now that bug 399783 depends on this, remove some additional lines.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 285609 [details] [diff] [review]
v1.1

This now additionally gets rid of gDownloadsOtherLabel.

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 285609 [details] [diff] [review]
v1.1

r=sdwilsh

Comment 11

[Damon Sicore (:damons)]

Comment on attachment 284887 [details] [diff] [review]
for checkin

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 12

[Damon Sicore (:damons)]

Comment on attachment 284887 [details] [diff] [review]
for checkin

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 13

[Ed Lee :Mardak]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.96; previous revision: 1.95
done
Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.32; previous revision: 1.31
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.18; previous revision: 1.17
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.22; previous revision: 1.21
done

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102721 Minefield/3.0a9pre

and Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102720 Minefield/3.0a9pre

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Updated the testcases in Litmus to remove reference to the "Active" and "Completed" sections, but left in "Active" and "Completed" as concepts, as that's the broadest and easiest way to refer to those categories.

in-litmus+