Closed Bug 399781 Opened 15 years ago Closed 15 years ago

Remove headings in Download Manager UI

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9beta1

People

(Reporter: sdwilsh, Assigned: Mardak)

References

Details

Attachments

(1 file, 2 obsolete files)

As per mockup in Bug 397655.

Requesting [wanted-firefox3]
Flags: blocking-firefox3?
Blocks: 392256
Blocks: 396596
Assignee: comrade693+bmo → nobody
Status: ASSIGNED → NEW
Component: Disability Access → Download Manager
OS: Mac OS X → All
QA Contact: disability.access → download.manager
Hardware: PC → All
Attached patch v1 (obsolete) — Splinter Review
Blank out the titles -> make them placeholder hbox areas so that we can do easy priority-queue-like insertion.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #284865 - Flags: review?(comrade693+bmo)
Patch depends on bug 399783 + some fixes I added myself.. :p
Depends on: 399783
Comment on attachment 284865 [details] [diff] [review]
v1

>-var gDownloadsActiveTitle = null;
>-var gDownloadsOtherTitle  = null;
>+var gDownloadsActiveArea = null;
>+var gDownloadsDoneArea = null;
nit: please line up the =

>-  gDownloadsActiveTitle = document.getElementById("active-downloads-title");
>-  gDownloadsOtherTitle  = document.getElementById("other-downloads-title");
>+  gDownloadsActiveArea = document.getElementById("active-downloads-area");
>+  gDownloadsDoneArea = document.getElementById("done-downloads-area");
ditto
Attachment #284865 - Flags: review?(comrade693+bmo)
Attachment #284865 - Flags: review+
Attachment #284865 - Flags: approval1.9?
(In reply to comment #3)
> nit: please line up the =
I was thinking about lining them up.. but then a previous style guide said to not try lining up stuff with spaces because it won't work :p But that was probably in relation to using tabs for indenting.

Additionally, if I did go with gDownloadsCompletedArea, I would have had to extend all the other spaces to match up with the now-longer-one which would cause unnecessary blame loss.
I prefer Done over Complete anyway, so we have no problem.
Attached patch for checkin (obsolete) — Splinter Review
Added spaces.
Attachment #284865 - Flags: approval1.9?
Comment on attachment 284887 [details] [diff] [review]
for checkin

r=sdwilsh

No logic is actually changing here, so this is low risk.
Attachment #284887 - Flags: review+
Attachment #284887 - Flags: approval1.9?
Attachment #284887 - Flags: approval1.9? → approval1.9+
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][has reviews]
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Blocks: 399783
No longer depends on: 399783
Attached patch v1.1Splinter Review
Now that bug 399783 depends on this, remove some additional lines.
Attachment #284865 - Attachment is obsolete: true
Attachment #284887 - Attachment is obsolete: true
Comment on attachment 285609 [details] [diff] [review]
v1.1

This now additionally gets rid of gDownloadsOtherLabel.
Attachment #285609 - Flags: review?(comrade693+bmo)
Whiteboard: [has patch][has reviews] → [has patch]
Comment on attachment 285609 [details] [diff] [review]
v1.1

r=sdwilsh
Attachment #285609 - Flags: review?(comrade693+bmo) → review+
Comment on attachment 284887 [details] [diff] [review]
for checkin

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.
Comment on attachment 284887 [details] [diff] [review]
for checkin

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.
Attachment #284887 - Flags: approval1.9+
Attachment #285609 - Flags: approval1.9?
Attachment #285609 - Flags: approvalM9+
Attachment #285609 - Flags: approval1.9?
Attachment #285609 - Flags: approval1.9+
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.96; previous revision: 1.95
done
Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.32; previous revision: 1.31
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.18; previous revision: 1.17
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.22; previous revision: 1.21
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: Firefox 3 M10 → Firefox 3 M9
Verified FIXED using

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102721 Minefield/3.0a9pre

and Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102720 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
Updated the testcases in Litmus to remove reference to the "Active" and "Completed" sections, but left in "Active" and "Completed" as concepts, as that's the broadest and easiest way to refer to those categories.

in-litmus+
Flags: in-litmus? → in-litmus+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.