Remove unused nsIFocusController::GetPopupEvent/SetPopupEvent
RESOLVED
FIXED
in mozilla1.9beta2
Status
()
People
(Reporter: mats, Assigned: mats)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
6.06 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Remove unused nsIFocusController::GetPopupEvent/SetPopupEvent History: introduced by bug 302050 http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/xul/content/src/nsXULPopupListener.cpp&rev=1.136&cvsroot=/cvsroot&mark=285#285 then some more work in bug 335291 then all usage was removed by bug 279703
|
(Assignee) | |
Comment 1•11 years ago
|
||
Created attachment 285189 [details] [diff] [review] Patch rev. 1
Attachment #285189 -
Flags: superreview?(bzbarsky)
Attachment #285189 -
Flags: review?(bzbarsky)
|
||
Updated•11 years ago
|
||
Attachment #285189 -
Flags: superreview?(bzbarsky)
Attachment #285189 -
Flags: superreview+
Attachment #285189 -
Flags: review?(bzbarsky)
Attachment #285189 -
Flags: review+
|
|
(Assignee) | |
Comment 2•11 years ago
|
||
Comment on attachment 285189 [details] [diff] [review] Patch rev. 1 Removing dead code, zero risk.
Attachment #285189 -
Flags: approval1.9?
|
||
Comment 3•11 years ago
|
||
Comment on attachment 285189 [details] [diff] [review] Patch rev. 1 a=release drivers
Attachment #285189 -
Flags: approval1.9? → approval1.9+
|
||
Updated•11 years ago
|
||
Keywords: checkin-needed
|
|
(Assignee) | |
Comment 4•11 years ago
|
||
mozilla/dom/public/base/nsIFocusController.h 1.21 mozilla/dom/src/base/nsFocusController.cpp 1.62 mozilla/dom/src/base/nsFocusController.h 1.22 -> FIXED
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
|
||
Comment 5•11 years ago
|
||
I backed this out to see if it fixes the orange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•11 years ago
|
||
Relanded.
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•