400355 - "WARNING: GetGeckoKeyCodeFromChar has failed" pressing right shift or right cmd

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Press the *right* shift or *right* cmd key on a macbook pro.

Result:
WARNING: GetGeckoKeyCodeFromChar has failed.: file /Users/jruderman/trunk/mozilla/widget/src/cocoa/nsChildView.mm, line 3275

This is annoying because it clutters up the console when I type.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Josh:

Do you know the keycode for right shift and right cmd? If you tell them, I'll add them to next patch for bug 399740.

# my keyboard doesn't have right cmd...

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Don't we have same problem on "right option" key?

Comment 3

[Jesse Ruderman]

I don't know.  My keyboard doesn't have a right option key.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> Don't we have same problem on "right option" key?

Yes, it seems we do, and with "right control" as well.  (I borrowed my brother's old Pro Keyboard tonight to check this.)

Comment 5

[jag (Peter Annema)]

Is there a way nsChildView.mm can tell me these keycodes? I have right option, cmd and shift on my keyboard.

Comment 6

[jag (Peter Annema)]

It looks like they're the following, at least for me:

right-command: 0x36
right-shift:   0x3C
right-option:  0x3D
right-control: 0x3E

I basically added a warning to ConvertMacToGeckoKeyCode() that prints out the keyCode and those are the values I got.

Comment 7

[Josh Aas]

Attachment: fix v1.0

Comment 8

[Josh Aas]

landed on trunk