400463 - firefox-2.0.0.8 build break due to relocation error on amd64 - missing system header

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.8.1.8) Gecko/20071019 Firefox/2.0.0.8
Build Identifier: 

bug349906 was ported back to the 1.8 Branch. Now, the brandnew downloaded firefox-2.0.0.8 sources fail to compile due to gdk/gdkpango.h missing from the system headers with a relocation error output
For the error message see http://bugs.gentoo.org/show_bug.cgi?id=196444

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Walter Meinl]

Attachment: add gdkpango.h to system-headers

The patch also corrects the configure check for pango pc files as pangoxft is not needed anymore after the branch checkin for bug349906 and therefore why should we check for it?

Comment 2

[Walter Meinl]

the same header was already added to the the trunk system-headers in bug362682

Comment 3

[Walter Meinl]

hrrmm, sorry, missed to add an important information the build breaks only with gcc >= 4.2

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 285522 [details] [diff] [review]
add gdkpango.h to system-headers

approved for 1.8.1.10, a=dveditz for release-drivers

Comment 5

[Reed Loden [:reed]]

MOZILLA_1_8_BRANCH:

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1503.2.106; previous revision: 1.1503.2.105
done
Checking in config/system-headers;
/cvsroot/mozilla/config/system-headers,v  <--  system-headers
new revision: 3.4.4.4; previous revision: 3.4.4.3
done

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Walter, can you verify that this is fixed?

Comment 7

[Walter Meinl]

(In reply to comment #6)
> Walter, can you verify that this is fixed?
> 
Yes, thanks to all helping to get this in