Closed
Bug 400463
Opened 17 years ago
Closed 17 years ago
firefox-2.0.0.8 build break due to relocation error on amd64 - missing system header
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: wuno, Assigned: wuno)
Details
(Keywords: verified1.8.1.10)
Attachments
(1 file)
1.10 KB,
patch
|
roc
:
review+
dveditz
:
approval1.8.1.10+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.8.1.8) Gecko/20071019 Firefox/2.0.0.8 Build Identifier: bug349906 was ported back to the 1.8 Branch. Now, the brandnew downloaded firefox-2.0.0.8 sources fail to compile due to gdk/gdkpango.h missing from the system headers with a relocation error output For the error message see http://bugs.gentoo.org/show_bug.cgi?id=196444 Reproducible: Always Steps to Reproduce: 1. 2. 3.
Assignee | ||
Comment 1•17 years ago
|
||
The patch also corrects the configure check for pango pc files as pangoxft is not needed anymore after the branch checkin for bug349906 and therefore why should we check for it?
Attachment #285522 -
Flags: review?(roc)
Assignee | ||
Comment 2•17 years ago
|
||
the same header was already added to the the trunk system-headers in bug362682
Version: unspecified → 1.8 Branch
Assignee | ||
Comment 3•17 years ago
|
||
hrrmm, sorry, missed to add an important information the build breaks only with gcc >= 4.2
Attachment #285522 -
Flags: review?(roc) → review+
Updated•17 years ago
|
Assignee: nobody → wuno
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•17 years ago
|
Attachment #285522 -
Flags: approval1.8.1.9?
Attachment #285522 -
Flags: approval1.8.1.8?
Updated•17 years ago
|
Attachment #285522 -
Flags: approval1.8.1.8?
Comment 4•17 years ago
|
||
Comment on attachment 285522 [details] [diff] [review] add gdkpango.h to system-headers approved for 1.8.1.10, a=dveditz for release-drivers
Attachment #285522 -
Flags: approval1.8.1.10? → approval1.8.1.10+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 5•17 years ago
|
||
MOZILLA_1_8_BRANCH: Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1503.2.106; previous revision: 1.1503.2.105 done Checking in config/system-headers; /cvsroot/mozilla/config/system-headers,v <-- system-headers new revision: 3.4.4.4; previous revision: 3.4.4.3 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed → fixed1.8.1.10
Resolution: --- → FIXED
Assignee | ||
Comment 7•17 years ago
|
||
(In reply to comment #6) > Walter, can you verify that this is fixed? > Yes, thanks to all helping to get this in
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.10 → verified1.8.1.10
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•