401092 - Bookmark Icons (favicons) disappear

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Pascal Herbert]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre

After installing the Minefield 2007102504 the bookmarks Icons disappears when I clicked on them.

Reproducible: Always

Steps to Reproduce:
1.Click on a bookmark
2.Waiting till page is fully loaded
3.Icon, of the bookmark I click on goes away


Expected Results:  
Icon don't go.

Comment 1

[Brian Polidoro]

I've seen this on some of my bookmarks.  I see it on the bookmark toolbar and the menu but not the sidebar. I've even seen a case where the bookmark menu and toolbar don't agree i.e. one shows the icon while the other doesn't.  The icon usually seems to alternate to be there and not be there when visiting the site over and over.  

Seems to be new with this nightly.  One site that shows it well for me is weather.com.  
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre ID:2007102504

Comment 2

[Peter van der Woude [:Peter6]]

In bookmarks menu
Click on a bookmark -> result, the bookmark opens and icon disappears
Click on the same bookmark (now with the generic generic icon) -> result, the page is reopened and the bookmark reappears 

Comment 3

[Peter van der Woude [:Peter6]]

regressionwindow:
works in 20071024_1818_firefox-3.0a9pre.en-US.win32
fails in 20071024_1906_firefox-3.0a9pre.en-US.win32

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1193275080&maxdate=1193277959&cvsroot=%2Fcvsroot

->Bug 399729

Comment 4

[Hideo Oshima]

I can reproduce with recent trunk Linux build.

Comment 5

[Justin Dolske [:Dolske]]

I'm seeing this on OS X as well, yesterday I just had a couple of bookmarks icons revert to default, and now I've got a couple folders full of default icons.

Nominating for a beta blocker; although disappearing favicons are not breaking functionality it's a highly visible regression and people will complain. (This seems to have been regressed by bug 399729).

Comment 7

[(not reading, please use [e-mail] instead)]

mano, this regression appears to be related to bug #399729

Comment 8

[Dave Townsend [:mossop]]

Looks like the bookmark isn't being forgotten by places, just the menu view. If I exit then reopen firefox the favicons that were gone are back again.

Comment 9

[Asaf Romano (gone)]

I wasn't able to reproduce this.. STR with a new profile would help a lot.

Comment 10

[Dave Townsend [:mossop]]

From a new profile:

1. Visit http://www.mozilla.org
2. Click the star button
3. Click it again and put the bookmark into the bookmarks menu
4. Open the bookmarks menu, see bookmark with red dinosaur icon, click it.
5. after the page has loaded open the bookmarks menu a few times, the icon disappears a few seconds after the page loaded.
6. Click the bookmark again. A few seconds after page load the icon will appear in the menu again.

Comment 11

[Asaf Romano (gone)]

Attachment: patch

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 286768 [details] [diff] [review]
patch

as mano pointed out over irc, if we have an iconURI but the image matched the spec, we'd call removeAttribute (instead of doing nothing.)

thanks for the quick fix, mano.

Comment 13

[Asaf Romano (gone)]

mozilla/browser/components/places/content/menu.xml 1.91
mozilla/browser/components/places/content/toolbar.xml 1.110

Comment 14

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007103018 Minefield/3.0a9pre ID:2007103018

VERIFIED

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv