401333 - Can't expand folder tree of Edit bookmark dialog [Exception... "'Illegal value' when calling method: [nsITreeView::isContainerOpen]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"]

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Hideo Oshima]

Can't expand folder tree of Edit Bookmark dialog.

Error message are displayed in the Error Console:
Error: uncaught exception: [Exception... "'Illegal value' when calling method: [nsITreeView::isContainerOpen]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/editBookmarkOverlay.js :: EIO_toggleFolderTreeVisibility :: line 574"  data: no]

Steps to reproduce:
1. Click star button on the location bar to open Edit bookmark dialog.
2. Click small triangle button right side of "Folder".

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007102604 Minefield/3.0a9pre

Comment 1

[(not reading, please use [e-mail] instead)]

I think this is a recent regression.

Comment 2

[pal-moz]

http://forums.mozillazine.org/viewtopic.php?p=3113536#3113536

bug 373944 cause this.

Comment 3

[Asaf Romano (gone)]

Attachment: set the place only once the tree has a frame

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 286396 [details] [diff] [review]
set the place only once the tree has a frame

r=sspitzer, thanks for the quick fix mano.

on a related note, do we need to worry about moveBookmarks.xul?

Comment 5

[Asaf Romano (gone)]

hrm, moveBookmarks.xul doesn't hide its tree.

Comment 7

[Asaf Romano (gone)]

mozilla/browser/components/places/content/editBookmarkOverlay.js 1.9
mozilla/browser/components/places/content/editBookmarkOverlay.xul 1.8
mozilla/browser/components/places/content/tree.xml 1.85

Comment 8

[Hideo Oshima]

I confirmed the problem is fixed with new build.
Thanks a lot.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using the steps to reproduce from this bug and:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007110106
Minefield/3.0a9pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9a9pre)
Gecko/2007110105 Minefield/3.0a9pre

and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007103103 Minefield/3.0a9pre

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv