401820 - "Warning: XUL box for hbox element contained an inline span child" on preview

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Justin Wood (:Callek)]

When viewing a feed preview for MDC (http://developer.mozilla.org/en/docs/index.php?title=Special:Recentchanges&feed=rss)

I hit the following warning:

Warning: XUL box for hbox element contained an inline span child, forcing all its children to be wrapped in a block.
Source File: http://developer.mozilla.org/en/docs/index.php?title=Special:Recentchanges&feed=rss
Line: 0

Fallout from Bug 321402

Comment 1

[Reed Loden [:reed]]

http://mxr.mozilla.org/mozilla/source/browser/components/feeds/content/subscribe.xhtml#43

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This doesn't block, but would take fix.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Was there a change in the appearance of the UI in question?  I'd expect there would be...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot (before bug, top; with bug, bottom)

Note that the "Subscribe Now" button moved.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: format the code more legibly (no code changes)

I've used this approach before for formatting markup that couldn't have whitespace in it -- I think it's a bit saner than all-on-one-line.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This removes the span -- I'm not sure why it was there, and things lay out the way they used to once I remove it.  This fixes the bug.

This applies on top of the previous patch.

Comment 7

[Asaf Romano (gone)]

I've added that span to work-around bug 349477, which is fixed now.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 286938 [details] [diff] [review]
patch

r=mano

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286938 [details] [diff] [review]
patch

a=drivers for after M9

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286937 [details] [diff] [review]
format the code more legibly (no code changes)

a=drivers for after M9

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.