40196 - Images in btn controls in tables not tiling correctly

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[rods (gone)]

Load the attachment and notice how only the 4th button looks correct. The other 
have an extra pixel being drawn on the right.

Comment 1

[rods (gone)]

Attachment: somewhat simple example

Comment 2

[rods (gone)]

Nominating for nsbeta2 because of visual badness

Comment 3

[rods (gone)]

Also, note that if you remove or comment out the 
"background-repeat:no-repeat;" style property it does tile well at all. Also, 
the tiled image "arrow.gif" is 7x4 pixels.

Comment 4

[dcone (gone)]

Is this a regression or a new feature.

Comment 5

[dcone (gone)]

I get all blank buttons.  The background image does not draw.

Comment 6

[dcone (gone)]

I can't reproduce.. I don't get background images at all, or combo boxes at all, 
they look like checkbox buttons.

Comment 7

[rods (gone)]

Sorry, save the attachment to the mozilla/.../bin/res/samples the "arrow.gif" 
should then be picked up. If not the arrow.gif is in the "res" directory and you 
can copy it up to the samples directory and that will definitiely work.

Comment 8

[dcone (gone)]

Found the problem, low risk fix.
Have fix in hand, two line fix in nsRenderingContextWin.cpp

Comment 9

[rods (gone)]

The comment "two line fix" really means "very low risk"

Comment 10

[dcone (gone)]

nsRendeirngContextWin::DrawTile()

 // pop aX1 and aY1 onto a pixel boundary
 aX1 = aX0 + (((aX1-aX0)/aWidth)*aWidth);
 aY1 = ay0 + (((aY1-aY0)/aHeight)*aHeight);

Comment 11

[Peter Trudelle]

[nsbeta2+] [6/15]

Comment 12

[dcone (gone)]

The fix puts the adds in an error for aX1 and aY1. 

Line 2848

 // convert output platform, but no translation.. just scale
  orgX = aX0;
  orgY = aY0;
  orgWidth = aX1 - aX0;
  orgHeight = aY1 - aY0;
  mTranMatrix->TransformCoord(&aX0,&aY0,&aWidth,&aHeight);
  mTranMatrix->TransformCoord(&orgX,&orgY,&orgWidth,&orgHeight);
  aX1 = aX0 + orgWidth;
  aY1 = aY0 + orgHeight;

Comment 13

[dcone (gone)]

Checked in changes.

Comment 14

[Chris Petersen]

Fixed in the June 20th build.