402298 - Random base64 file names can contain '/'

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Ed Lee :Mardak]

Base64 has alphanumeric and '+' and '/'. This causes problems with CreateUnique after setting the leafName.

Comment 1

[Ed Lee :Mardak]

Oh, for those curious, this results in the temporary file downloads to be <parent directory>-1

e.g.,
windows: c:\doc..local settings\Temp-1, Temp-2, etc
os x: /Users/Ed/Desktop-1

Comment 2

[Ed Lee :Mardak]

he he he...

[11/02/2007 14:39:12] <Mardak> unless there's some non-determinism [...] i would assume it gives the same results each time 

I guess we know where the non-determinism is coming from ;)

1 illegal character out of 64.. picking 8 characters: probability of a filename without an illegal character: (63/64)^8 = 88% of the time -> one in 8.4 downloads.

Comment 3

[Ed Lee :Mardak]

Attachment: v1

die slash die.

Comment 4

[Shawn Wilsher :sdwilsh]

This should block due to the issues it causes.

Comment 5

[Mike Connor [:mconnor]]

Yes, this is needed to fully resolve an existing blocker.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 287186 [details] [diff] [review]
v1

r+sr=jst to get this in for beta.

Comment 7

[Ed Lee :Mardak]

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.355; previous revision: 1.354
done

I suppose for a testcase, we would have to generate a large number of calls to SetUpTempFile and see if any randomly turn out to be "Desktop-1" or "Temp-1" instead of "<file>.<ext>.part".

For litmus.. "start a bunch of open-with downloads and see if they create a the correct temporary file"