402367 - restore compatibility wrapper for getLocalizedString: for prefPanes

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

UserAgent uses getLocalizedString:, at least, and now somebody's throwing an exception and leaving Camino dead when trying to open it (post-de-getification).

It'd be nice if we didn't knowingly leave this broken for a1, I think, but I don't know if that's reasonable or not.

Comment 1

[Stuart Morgan]

Attachment: fix

Comment 3

[Mark Mentovai]

Comment on attachment 287244 [details] [diff] [review]
fix

Where's the @interface?

Comment 4

[Stuart Morgan]

Withheld to protect the innocent.

Code shouldn't be compiled against those functions (especially not our own), since they are just there for binary compatibility, so they are not part of any interface, even a private one.

Comment 5

[Mark Mentovai]

Comment on attachment 287244 [details] [diff] [review]
fix

worksforme sr=me

Comment 6

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH. You may now return to your regularly scheduled spoofing.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Unfortunately, UserAgent is still hanging up on this on my 10.3.9 Mac (with the same "Camino[3363] *** -[UserAgentPref getLocalizedString:]: selector not recognized" console spew).  (It's fine on 10.5 with the very same copy of the app.)

Stuart had me try to add the @interface back, but that doesn't seem to help, either.  I don't know if I'm just horked somehow, or if there's a real issue on 10.3.9, or what :(

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 7 appears to have been the result of some sort of cruft in my org.mozilla.camino.plist (the recent .navigation -> .general and bundle_loader stuff relating to .privacy caused similar issues that I was smart enough to check against a fresh .plist this time around).

With a fresh .plist, I have returned to my regularly scheduled spoofing on 10.3.9.