402534 - Provide a default set of categories

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Michael Büttner (no reviews TFN)]

Currently, we don't come up with a default set for categories in the preference panel. That's because we initialize the categories with an empty string, see [1]. There's already a list of categories available (categories.properties, see [2]), but it doesn't get installed in the preferences and we don't provide a default set of color for those.

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/lightning/content/lightning.js#97
[2] http://lxr.mozilla.org/mozilla1.8/source/calendar/locales/en-US/chrome/calendar/categories.properties#39

Comment 1

[Stefan Sitter [:ssitter]]

This only applies to Lightning because Lightning can't ship localized preferences. See existing Bug 382967.

Comment 2

[Simon Paquet [:sipaq]]

It would be good to have this in 0.8

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: init categories from categories.properties

Comment 4

[Daniel Boelzle [:dbo]]

Comment on attachment 293302 [details] [diff] [review]
init categories from categories.properties

>         var categories = document.getElementById("calendar.categories.names").value;
>+
>+        // If no categories are configured load a default set from properties file
>+        if ( !categories || categories == "" ) {
remove spaces ^                               ^
>+            categories = calGetString("categories", "categories");
>+            document.getElementById("calendar.categories.names").value = categories;
>+        }
>+
>         gCategoryList = categories.split(",");
I'd prefer to outsource the above code to e.g. calGetCategories() in calUtils.js (unless bug 409950 is resolved).

looks fine, r=dbo

Comment 5

[Daniel Boelzle [:dbo]]

forget my comment about outsourcing that stuff; it's different

Comment 6

[Simon Paquet [:sipaq]]

Stefan, what's up with the patch here in the bug? Can it be checked in?

Comment 7

[Stefan Sitter [:ssitter]]

This already can be checked in with the styling nits (spaces) from Comment #4 fixed. Otherwise I'll provide an updated patch within the next days.

Comment 8

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

VERIFIED with 2008012320 and Win XP.

Comment 10

[Stefan Sitter [:ssitter]]

This needs to be reopened because the fix has been removed by Bug 321010, at least the fix in mozilla/calendar/base/content/preferences/categories.js.

Comment 11

[Stefan Sitter [:ssitter]]

Attachment: apply the fix again

To test the patch directly go to the preference dialog after installing Lightning. Without the patch no categories are displayed, with the patch the default set should be displayed.

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 305017 [details] [diff] [review]
apply the fix again

Moving review to berend since I will be away until thursday

Comment 13

[Berend Cornelius]

Comment on attachment 305017 [details] [diff] [review]
apply the fix again

Your patch works, but you should use the function "getPrefCategoriesArray" in calUtils.js; r=berend

Comment 14

[Stefan Sitter [:ssitter]]

getPrefCategoriesArray() can't be used because we don't read/write the preference but the dialog item that is connected to the preference system.

Comment 15

[Berend Cornelius]

But why is this use-case different from the other usecases (see 'appendCategoryItens' used by the calender-event dialog and by the task-category menu). There we also fill up menus and initialize the preferences if no categories are set on the way.

Comment 16

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

=> FIXED