402592 - labelMessage.label is unused (and some other cleanup)

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Looking at http://lxr.mozilla.org/mozilla/search?string=labelMessage.label, it seems like this entity is now unused, and replaced by addTag.label: http://lxr.mozilla.org/mozilla/search?string=addTag.label .

Perhaps labelMessage should now be removed in such case?

also, not part of this bug, but is the word "Label" intended here: http://lxr.mozilla.org/mozilla/source/mail/locales/en-US/chrome/messenger/search-attributes.properties#52 ?

Comment 1

[Magnus Melin [:mkmelin]]

I think the one in search-attributes.properties needs to stay for backward-compatibility.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

There is actually a lot of unused strings in that file.
Included in this patch is also some other removes of unused strings, and fix a strict warning.

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 288143 [details] [diff] [review]
proposed fix

r=philringnalda, always good to see the bad words go away :)

Comment 4

[David :Bienvenu]

Comment on attachment 288143 [details] [diff] [review]
proposed fix

thx for the patch

Comment 5

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #1)
> I think the one in search-attributes.properties needs to stay for
> backward-compatibility.
> 

BW compatibility with what?

Comment 6

[Magnus Melin [:mkmelin]]

Compatibility with older data that haven't been converted to tags yet, at least. 
http://mxr.mozilla.org/seamonkey/search?string=nsMsgSearchAttrib%3A%3ALabel

Comment 7

[Magnus Melin [:mkmelin]]

Checking in mail/extensions/newsblog/content/feed-subscriptions.js;
/cvsroot/mozilla/mail/extensions/newsblog/content/feed-subscriptions.js,v  <--  feed-subscriptions.js
new revision: 1.20; previous revision: 1.19
done
Checking in mail/locales/en-US/chrome/messenger/FilterEditor.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/FilterEditor.dtd,v  <--  FilterEditor.dtd
new revision: 1.9; previous revision: 1.8
done
Checking in mail/locales/en-US/chrome/messenger/messenger.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd,v  <--  messenger.dtd
new revision: 1.69; previous revision: 1.68
done
Checking in suite/locales/en-US/chrome/mailnews/FilterEditor.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/FilterEditor.dtd,v  <--  FilterEditor.dtd
new revision: 1.37; previous revision: 1.36
done
Checking in suite/locales/en-US/chrome/mailnews/messenger.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/messenger.dtd,v  <--  messenger.dtd
new revision: 1.221; previous revision: 1.220
done

->FIXED