402810 - Omnibus ad-blocking bug for November/December 2007 and January 2008

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

New month, new bug, new ads to block!

Comment 1

[philippe (part-time)]

In the latest version of ad-bl0cking.css

There is a sort of typo: a space between ! and important.
The ruleblock(s) work/is valid, it is just a minor aesthetic nitpicking :-)

e.g.
@-moz-document domain(mail.google.com) {                                        
div#rhc>div.rh,
div.slwyWc {display: none ! important }                                    
}

I found 3 occurrences of this.

Comment 2

[Chris Lawson (gone)]

From feedback:

"I thought that you should know that, lately, quite a few advertisements have been sneaking into my yahoo! mailbox page."

I told the guy to post the HTML source (stripped of any personal info) here so we can track down the source of the ads, but in case anyone sees them in the interim...

Comment 3

[Chris Lawson (gone)]

From the same feedback correspondent, an ad sometimes sneaks through on:

http://news.yahoo.com/s/nm/20071126/en_nm/britain_mi6_dc

The offending HTML source after I was able to reproduce with a clean profile:

<NOSCRIPT><A HREF="http://us.ard.yahoo.com/SIG=12go2jcvq/M=625044.11826067.12295791.1414694/D=news/S=7666378:LREC/_ylt=A0WTcUPQaktHcEoAgwrK.nQA/Y=YAHOO/EXP=1196132080/A=5051064/R=1/id=noscript/*http://ts.richmedia.yahoo.com/re/A=57,AN=300x250_20_products,AC=,AV=,PB=1/SIG=14emfcj06,X=1196124880,B=5051064,C=625044.11826067.12295791.1414694,D=LREC,Z=,R=news,P=BduS2UWTcupD.C41MmMavwXFTNRESEdLatAADHa3,E=7666378,Y=YAHOO,V=1.0/0/0/tc,c:noscript/http://altfarm.mediaplex.com/ad/ck/3484-54306-1039-6"><IMG SRC="http://ts.richmedia.yahoo.com/re/A=57,AN=300x250_20_products,AC=,AV=,PB=1/SIG=14emfcj06,X=1196124880,B=5051064,C=625044.11826067.12295791.1414694,D=LREC,Z=,R=news,P=BduS2UWTcupD.C41MmMavwXFTNRESEdLatAADHa3,E=7666378,Y=YAHOO,V=1.0/0/0/in,ti/http://richmedia.yimg.com/customer/57/57/300x250_backup.gif?adxq=1195426444" BORDER=0></A></NOSCRIPT></td></tr></table><script language=javascript>
if(window.yzq_d==null)window.yzq_d=new Object();
window.yzq_d['S7tkUELEYrI-']='&U=13bhj3gsa%2fN%3dS7tkUELEYrI-%2fC%3d625044.11826067.12295791.1414694%2fD%3dLREC%2fB%3d5051064';
</script>

Using MODI to inspect the generated source of the page, here's some more useful info:

    * width : 300
    * height : 250
    * quality : autohigh
    * wmode : opaque
    * menu : false
    * base : http://richmedia.yimg.com/customer/57/57/
    * flashvars : adxdom=news.yahoo.com&adxclick=adx_fc_4065&clickT AG1=http%3a//altfarm.mediaplex.com/ad/ck/3484%2d5 4306%2d1039%2d6&clickTAG2=http%3a//altfarm.mediap lex.com/ad/ck/3484%2d54306%2d1039%2d6&clickTAG3=h ttp%3a//altfarm.mediaplex.com/ad/ck/3484%2d54306% 2d1039%2d7&clickTAG4=http%3a//altfarm.mediaplex.c om/ad/ck/3484%2d54306%2d1039%2d8&adxcom=javascrip t
    * src : http://richmedia.yimg.com/customer/57/57/300x250_ 20_products.swf?adxq=1195426750
    * allowscriptaccess : always
    * type : application/x-shockwave-flash
    * id : adx_img_4065

Comment 4

[sairuh (rarely reading bugmail)]

When you vote for a comic at http://topwebcomics.com/ you'll get a Flash movie ad from splastk.com which appears in the upper-right of the page. For example,

http://www.splastk.com/syndicated/SplastkPlayer_v7.swf?video_xml_url=http://www.splastk.com/syndicated/video_xml.6.xml&client_id=6&allow_auto_preroll=true

To test, click on any of the "Vote for [comic_name]" links at http://topwebcomics.com/

Comment 5

[sairuh (rarely reading bugmail)]

Articles at New Scientist sometimes display Flash ads from adtech.panthercustomer.com. For example,

http://technology.newscientist.com/channel/tech/dn12977-colour-xray-machine-sees-so-much-more.html?feedId=online-news_rss20

had an ad on the right side from

http://adtech.panthercustomer.com/apps/173/Ad1584813St3Sz170Sq1111718V0Id1/200711_USA_shuttle_mpu.swf?targetTAG=_blank&clickTarget=_blank&pathTAG=http%3A//adtech.panthercustomer.com/apps/173/Ad1584813St3Sz170Sq1111718V0Id1/&closeTAG=javascript%3AcloseAdLayer113580%28%29&openTAG=javascript%3AopenAdLayer113580%28%29&expandTAG=javascript%3Aexpand113580%28%29&collapseTAG=javascript%3Acollapse113580%28%29&clicktarget=_blank&clickTarget=_blank&clickTARGET=_blank&CURRENTDOMAIN=technology.newscientist.com

Comment 6

[philippe (part-time)]

(In reply to comment #5)

That is the same adserver as bug 406311.

I looked up panthercustomer.com. I think it can be blocked completely.

Comment 7

[Simon Fraser [no longer active]]

Some Yahoo contextual ads showing up on SFGate.com 'Day in Pictures' page:

<div class="contextualad">
<div class="sfg_ysm001">
</div>
</div>

They are serviced by overture.com.

Comment 8

[Simon Fraser [no longer active]]

This got through on an sfgate.com story:
<span id="adviewer_div">
<div id="adx_ldo5_29638" style="overflow: hidden; position: relative; visibility: visible; left: 0px; top: 0px; z-index: 101; width: 728px; height: 90px; background-color: transparent;" onmouseover="adx_ls_29638[0]|=2;adx_ls_29638[1]|=2;adx_tr_29638('mov')" onmouseout="adx_ls_29638[0]&=~2;adx_ls_29638[1]&=~2;adx_tr_29638('mou')">
	<img id="adx_lo5_29638" src="sfgate%20Files/CSG_SWA_20071022_BOARD_728x90_v1.gif" onload="adx_pl_29638(5)" style="margin: 0px;" align="top" height="90" width="728">
	<div id="adx_al" style="position: absolute; cursor: pointer; top: 0px; left: 2px; width: 587px; height: 89px; z-index: 1; background-color: transparent;" onmouseover="adx_ls_29638[0]|=2;adx_ls_29638[1]|=2;" onmouseout="adx_ls_29638[0]&=~2;adx_ls_29638[1]&=~2;" onclick="adx_rp_29638();event.stopPropagation()">
	</div>
	<div id="adx_al" style="position: absolute; cursor: pointer; top: 32px; left: 592px; width: 110px; height: 28px; z-index: 1; background-color: transparent;" onmouseover="adx_ls_29638[0]|=2;adx_ls_29638[1]|=2;" onmouseout="adx_ls_29638[0]&=~2;adx_ls_29638[1]&=~2;" onclick="try{window.open(adx_P_29638+'http://tr.adinterax.com/re/'+adx_data_29638+'/'+adx_id_29638+'/'+adx_tr_29638('tc,ac,l5c,c:')+'/http://www.southwest.com/new/?src=new_NEWS_loc_111107','_blank','directories=1,location=1,menubar=1,resizable=1,scrollbars=1,status=1,toolbar=1')}catch(adx_e){}">
	</div>
</div>
</span>

Comment 9

[Chris Lawson (gone)]

We're blocking the Slate Video player on http://www.slatev.com/ .

<div id="main_video_content"><script type="text/javascript" language="javascript">writeFlash('null','980594949','917','606','http://ad.doubleclick.net/pfadx/slate.v.video/slatev')</script></div>

is the relevant snippet of code, and here's the JS for the writeFlash function:

function writeFlash(VideoID,PlayerID,Width,Height,AdServer) {
	document.write('<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://fpdownload.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=8,0,0,0" width="' + Width + '" height="' + Height + '" id="omniturePlayer" align="middle"><param name="allowScriptAccess" value="always" /><param name="movie" value="http://www.slatev.com/test/omniturePlayerV.swf?adServerURL=' + AdServer + '&amp;videoId=' + VideoID + '&amp;videoRef=null&amp;lineupId=null&amp;playerTag=null&amp;autoStart=true&amp;pwidth=' + Width + '&amp;pheight=' + Height + '&amp;playerId=' + PlayerID + '&amp;flashId=omniturePlayer&amp;swfFile=federated_f8.swf" /><param name="quality" value="high" /><param name="bgcolor" value="#333333" /><embed src="http://www.slatev.com/test/omniturePlayerV.swf?adServerURL=' + AdServer + '&amp;videoId=' + VideoID + '&amp;videoRef=null&amp;lineupId=null&amp;playerTag=null&amp;autoStart=true&amp;pwidth=' + Width + '&amp;pheight=' + Height + '&amp;playerId=' + PlayerID + '&amp;flashId=omniturePlayer&amp;swfFile=federated_f8.swf" quality="high" bgcolor="#333333" width="' + Width + '" height="' + Height + '" name="omniturePlayer" align="middle" allowScriptAccess="always" type="application/x-shockwave-flash" pluginspage="http://www.macromedia.com/go/getflashplayer" /></object>');
}

I guess we should probably be whitelisting Flash hosted on slatev.com.

cl

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Does Slate also serve Flash ads?  IIRC, they do.

Comment 11

[Chris Lawson (gone)]

I don't think the ads are actually hosted on slatev.com, at least from what I could see, but there might be a better/more specific way of whitelisting the player itself.

cl

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On MacFixIt:

iframe 
# id : madison_leader
# class : madison_ad style1
# src : http://mads.cnet.com/mac-ad?CELT=ifc&BRAND=1&SITE=1&_RGROUP=12073&OVERGIF=%3C%21--%20og%20--%3E

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And on versiontracker: 

iframe: http://bwp.versiontracker.com/search?style=leader board

div class="box-ad"
iframe src=http://bwp.versiontracker.com/search?ordinal=2

http://bwp.macfixit.com/ and http://bwp.versiontracker.com/ both serve only ads.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.nytimes.com/2007/12/30/travel/30armchair.html?_r=1&ex=1357189200&en=0f1bfa388df429dd&ei=5088&partner=rssnyt&emc=rss&oref=slogin

div id="adxSponLink"

Comment 15

[Stuart Morgan]

nasdaq.com screwed up their layout, and put everything on the stock quote pages (e.g., <http://www.nasdaq.com/includes/quotes_hub.stm>) in a div called 'panel_content_ads'. We've already had two reports of the site being "broken" in Camino, so we may need to partially whilelist them.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we fixed comment 15 for 1.5.5, we also changed the cbo exception to explicitly mention wiki.cbo (which is where that problem is, stupid MediaWiki).

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On versiontracker:

td class="todayTopAd" and td class="todayTopAd2"

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch

This fixes everything on this bug, on the two dep bugs, and everything that wasn't blocked and wasn't obviously "blockable but too common" from bug 407176.

Not sure about div[class="box"][id="dropin"] though; it blocks an annoying on-load floating div on widgetworld.nl, but the rule may be too generic to be safe.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and the MOZILLA_1_8_BRANCH in advance of b3.

If we do a 1.5.6, we should think about taking this then.

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Camino 1.5.6 is not happening.