402901 - trace_malloc_leaks on bm-xserve11 increase related to unified toolbar

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Peter Van der Beken [:peterv]]

There was an increase in trace_malloc_leaks on bm-xserve11 around Oct 30th and a decrease around Nov 5th:

http://build-graphs.mozilla.org/graph/query.cgi?tbox=bm-xserve11.build.mozilla.org&testname=trace_malloc_leaks&autoscale=1&size=&units=bytes&ltype=&points=&showpoint=2007%3A11%3A07%3A11%3A21%3A30%2C1008385&avg=1&days=10

Here are the checkins for the increase:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=10&date=explicit&mindate=2007-10-29+21%3A00%3A00&maxdate=2007-10-29+23%3A00%3A00&cvsroot=%2Fcvsroot

Here are the checkins for the decrease:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=10&date=explicit&mindate=2007-11-05+13%3A00%3A00&maxdate=2007-11-06+14%3A00%3A00&cvsroot=%2Fcvsroot

Seems like it's related to the unified toolbar (bug 303110 and bug 402125 are in those ranges). Filing this because afaik 402125 disabled unified toolbar but we will reenable that at some point.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

As far as I can tell bug 402125 *enabled* the unified toolbar feature that was implemented in 303110. I guess that would point to a problem with the modified code for the disabled or "normal" case?

Comment 2

[Colin Barrett [:cbarrett]]

Attachment: fix

Gavin, exactly what you said made me suspicious and I took a look at the leak information again, and then looked at the code.

Noticed I was not releasing the CGShadingRef!

Comment 3

[Colin Barrett [:cbarrett]]

Attachment: real fix

Attached the wrong patch.

Comment 4

[Colin Barrett [:cbarrett]]

reviewer information didn't make it in to the checkin comment, grr...

Checking in widget/src/cocoa/nsCocoaWindow.mm;
/cvsroot/mozilla/widget/src/cocoa/nsCocoaWindow.mm,v  <--  nsCocoaWindow.mm
new revision: 1.115; previous revision: 1.114
done