Closed
Bug 402125
Opened 18 years ago
Closed 18 years ago
Pinstripe theme should specify unified titlebar color (to look less clashy for beta)
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta1
People
(Reporter: mconnor, Assigned: asaf)
References
()
Details
Attachments
(1 file, 3 obsolete files)
|
7.31 KB,
patch
|
mconnor
:
review+
beltzner
:
approvalM9+
|
Details | Diff | Splinter Review |
We shouldn't have this odd Tiger/Leopard hybrid for now, see URL for a screenshot. has ui-r from beltzner on IRC
Attachment #287021 -
Flags: review?(mano)
Attachment #287021 -
Flags: approvalM9?
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: mconnor → mano
Attachment #287021 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #287022 -
Flags: review?(mconnor)
Attachment #287022 -
Flags: approvalM9?
Attachment #287021 -
Flags: review?(mano)
Attachment #287021 -
Flags: approvalM9?
|
||
Updated•18 years ago
|
Attachment #287022 -
Attachment is patch: true
Attachment #287022 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #287022 -
Attachment is obsolete: true
Attachment #287024 -
Flags: review?(mconnor)
Attachment #287024 -
Flags: approvalM9?
Attachment #287022 -
Flags: review?(mconnor)
Attachment #287022 -
Flags: approvalM9?
|
|
||
Updated•18 years ago
|
Version: unspecified → Trunk
|
||
Updated•18 years ago
|
Summary: clean up titlebar to look less clashy for beta → Pinstripe theme should specify unified titlebar color (to look less clashy for beta)
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #287024 -
Attachment is obsolete: true
Attachment #287072 -
Flags: review?(mconnor)
Attachment #287072 -
Flags: approvalM9?
Attachment #287024 -
Flags: review?(mconnor)
Attachment #287024 -
Flags: approvalM9?
|
||
Comment 4•18 years ago
|
||
Comment on attachment 287072 [details] [diff] [review]
remove the toolbar background
Can't approve unreviewed patches, mconnor can renom after he's done the review.
Attachment #287072 -
Flags: approvalM9?
|
||
Comment 5•18 years ago
|
||
So this will look tiger style on 10.5? :(
|
|
Reporter | |
Comment 6•18 years ago
|
||
That's better than the current icon set on Leopard toolbars, IMO, so I'm fine with that for now. I also don't want to get into a bunch of per-app chromereg stuff until we have time to fix fallout.
|
|
Reporter | |
Comment 7•18 years ago
|
||
Comment on attachment 287072 [details] [diff] [review]
remove the toolbar background
yeah, this looks great!
Attachment #287072 -
Flags: approvalM9?
|
|
Reporter | |
Updated•18 years ago
|
Attachment #287072 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•18 years ago
|
Flags: in-litmus+
Flags: blocking-firefox3?
|
|
||
Updated•18 years ago
|
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 287072 [details] [diff] [review]
remove the toolbar background
a=beltzner for M9
Attachment #287072 -
Flags: approvalM9? → approvalM9+
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: checkin-needed
|
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 9•18 years ago
|
||
mozilla/toolkit/themes/pinstripe/global/global.css 1.16
mozilla/toolkit/themes/pinstripe/global/jar.mn 1.36
mozilla/toolkit/themes/pinstripe/global/toolbar.css 1.9
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•18 years ago
|
||
mozilla/toolkit/themes/pinstripe/global/globalBindings.xml 1.22
|
||
Comment 11•18 years ago
|
||
This is not a good fix. It causes bad visual problems - the whole app looks albino and suffers badly from bug 402654 (check out the Preferences window). It is hard to tell when a window has focus or not because of the color.
Instead of turning on the unified look now we should just change the background color of the toolbar on 10.5 to match the darker title bar, or just back this patch out and do nothing for b1 (how could this possibly be a blocker anyway?). This solution's regressions are too bad to accept, imho. Makes the app look totally crazy, at least it looked like a Mac app before if a less-than-pretty one.
|
|
||
Comment 12•18 years ago
|
||
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; es-ES; rv:1.9a9pre) Gecko/2007110520 Minefield/3.0a9pre.
Toolbar is now showing a more uniform grey color.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•