403091 - search plug in review for Fx3 b1

Status: RESOLVED FIXED

(Mozilla Localizations :: sk / Slovak, defect)

Description

[Mic Berman]

review search parameters for soznam please - there is a change between Fx2 compared to what we have on trunk and we need to understand why

Comment 1

[Branislav Rozbora (Mozilla.sk)]

they are using hladaj.fcgi template and parameter "co" instead of previous used "c" by default now, so we have updated plugin according to these changes (icon was also updated). sorry we didn't request review.
BTW: mic, it is zoznam not soznam. You probably think so because of their czech equivalent seznam, am I right?

Comment 2

[Mic Berman]

Branislav
yep - sorry about that - too many search plug ins in my head ;-)

Comment 3

[Branislav Rozbora (Mozilla.sk)]

Axel, what's the status here. This really should not block releasing sk b1, this is not new plugin, just paramater change. And it is working of course. Thx.

Comment 4

[Mic Berman]

Branislav
for me: I need a contact name, title and email at zoznam and a forward of the email with request for the changes (icon etc)
back over to Axel
thanks
mic

Comment 5

[Axel Hecht [:Pike]]

As soon as Mic has her info, I'd be good.

To me, more important than the icon are the flag changes, of which there are two, the c->co, and the dropping of the sourceid flag.

The approval for adding azet-sk.xml was bug 395195, for reference, which is OK in its current incarnation. The other changes in list.txt are just reordering.

Note, changes to region.properties, as in the change to search engine ordering should be made explicitly, with patches, reviewed by me.

The changes to dunaj.sk should have been reviewed, too. That's an update to the icon, which looks ok looking at dunaj.sk, and a change to the description, which seems to match the current site title, too.

Mic, we're OK with the change of the second ordering from Atlas to Azet?

Comment 6

[Mic Berman]

ok, on changing ordering

re comment #4: i have this contact from zoznam, Branislav is that same for you? Mr. Debnar: [e-mail]

Comment 7

[Branislav Rozbora (Mozilla.sk)]

axel, new reordering was attached as part of bug 395195

mic, as we were informed today, Mr. Debnar is not working for zoznam anymore, we will let you know asap about new contact person details.

Comment 8

[Axel Hecht [:Pike]]

Branislav, mind pointing out the concrete attachment? If you're talking about attachment 280793 [details], that's a pretty implicit thing, and I did see that. That's why I called out for explicit patches for changes to region.properties for future changes, and you should, in particular for changes to search, use richer check-in comments. Right now, we're less doing a quick check of what changed, but more doing a deep depth archeology expedition.

That attachment is in the format of list.txt, too, which doesn't have any ordering, so it's not really apparent, and the bug doesn't call out the drop of ordering for Atlas at all, either.

Please understand that Slovak is one of several dozen localizations, and we can't keep everything in our head. Thus we need to have good check-in comments, which link from the cvs history of the files to bugs, and in those bugs, explicit and detailed information about why which change has been made.

Otherwise we end up where we are right now, sending confused mails back and forth, and maybe dropping localizations from releases.

Comment 9

[Branislav Rozbora (Mozilla.sk)]

OK, this thing was kind of misunderstanding. sorry. We will track similar changes in separate bugs in the future.

Comment 10

[Mic Berman]

hi
re: comment #5 changing sourceID for zoznam
this is kind of strange - did we do this on purpose on their behalf? it seems the only way that they would know where their searches were coming from.
if it is supposed to be this way we should get explicit request from them.
thanks!
mic

Comment 11

[Branislav Rozbora (Mozilla.sk)]

Mic, you should have an e-mail from Zoznam's Head of Development in your inbox now.

Comment 12

[Mic Berman]

Hi
got it. 
i will be following up with them just to understand better why they wanted it changed.
mic

Comment 13

[Axel Hecht [:Pike]]

Mic and I got feedback from Zoznam, they're don't need a fx-specific flag.

Resolving, with target milestone set to M9 to indicate that this happened in time for B1.