Closed Bug 403164 Opened 12 years ago Closed 12 years ago
Add Sparkle license to about:license on branch and trunk
Code for bug 185436 is about to be in-process on the MOZILLA_1_8_BRANCH and the trunk, so per bug 399977 comment 1, we need to add the Sparkle license to about:license. Gerv, I assume you're keeping (or trying to keep) all three copies of license.html in sync with each other (on the respective branches), but this code will only be a part of Camino. Given that, should we use a parenthetical (like with the Growl License) that says something to the effect of (This code only ships in the Camino browser or products based on it.) ? (Yes, people embed Camino in order to embed Gecko in Cocoa apps. For about:license do we care about uses of the code outside of mozilla.org projects, or just m.o ones?) I can do the patch(es) here once we have an answer about the wording.
Yeah, we should probably keep them all in sync, and do the "parenthetical" thing in the same way and with the same formatting we use for other stuff. (Does the Growl notice use parentheses?) We do care about projects outside of m.o; it's nice to make their lives easier. Gerv
"This license applies to certain files in the directory toolkit/components/alerts/src/mac/growl/. (This code only ships in the Mac OS X version of the product.)" I'll work up a patch based on that, then.
Here's a patch that uses the same wording style as other "only ships in foo", using the wording I proposed in comment 0.
Attachment #288418 - Flags: review?
There were a number of context changes that prevented the trunk patch from applying on the branch, so here's a self-contained branch patch.
Attachment #288419 - Flags: review?(gerv)
Comment on attachment 288418 [details] [diff] [review] trunk patch [checked in] (Who'd have thought there'd be more than one match for "gerv"?)
Attachment #288418 - Flags: review? → review?(gerv)
Attachment #288418 - Flags: review?(gerv) → review+
Attachment #288419 - Flags: review?(gerv) → review+
Do we need sr on these before requesting approvals to land, or is Gerv the final word on about:license changes?
Gerv's review should be sufficient.
Comment on attachment 288419 [details] [diff] [review] MOZILLA_1_8_BRANCH patch This is a simple license.html change which is needed for Camino to include the Sparkle framework for software updates.
Comment on attachment 288418 [details] [diff] [review] trunk patch [checked in] Whoops. Requested trunk approval on the wrong patch. This is a simple license.html change which is needed for Camino to include the Sparkle framework for software updates.
Attachment #288418 - Flags: approval1.9?
Attachment #288418 - Flags: approval1.9? → approval1.9+
Comment on attachment 288418 [details] [diff] [review] trunk patch [checked in] Checked in on the trunk; leaving this bug open until we get branch approval.
Attachment #288418 - Attachment description: trunk patch → trunk patch [checked in]
Comment on attachment 288419 [details] [diff] [review] MOZILLA_1_8_BRANCH patch approved for 18.104.22.168, a=dveditz If all these versions of the file are kept in sync we should only have one copy -- is there a bug on that?
Attachment #288419 - Flags: approval22.214.171.124? → approval126.96.36.199+
There are various bugs on the situation. Currently, I aware of bugs on the following (but don't have the numbers handy; philor can point you to those bugs better than I): 1) there are problems with non-browser apps being able to use the html+js transformed ones, 2) one version of the file is supposed to serve as a plain-text tarball-styled README, 3) there's currently no way for the toolkit version of the file to handle the trademark license/EULA information for non-MoCo products (bug 368091), 4) and we have to figure out something for XULRunner, too. Anyway, checked in to the MOZILLA_1_8_BRANCH; thanks all!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.