Closed Bug 403174 Opened 13 years ago Closed 11 years ago

[10.5] Sheets come out above toolbar instead of below it

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: samuel.sidler+old, Assigned: mstange)

References

(Depends on 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Native apps on 10.5 have sheets which come out below the toolbar. Firefox still has the behavior seen in 10.4, with the sheets coming out above the toolbar.
Flags: blocking-firefox3?
From the Appkit Release Notes on Sheets for 10.5:
> Due to compatibility concerns, the additional content border thickness is only
> taken into account for positioning the sheet if it has been set explicitly. 
> That is, if the window returns YES from [self
> autorecalculatesContentBorderThicknessForEdge:NSMaxYEdge], the auto-calculated
> content border thickness is not included when positioning the sheet.

So what we would need to do is use [window setContentBorderThickness:height_of_toolbar forEdge:NSMaxYEdge].

No idea how you would communicate that information to widget from XUL-land, and the new sheets only existing in content seems like it's a bad idea for security (safari sort of mitigates this by having it cover the tab bar, but if you don't have any tabs open...)
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Duplicate of this bug: 414584
Attached patch fix per comment #1 (obsolete) — Splinter Review
Bug 439354 makes this possible.
Attachment #332706 - Flags: superreview?(roc)
Attachment #332706 - Flags: review?(roc)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #332706 - Flags: superreview?(roc)
Attachment #332706 - Flags: superreview+
Attachment #332706 - Flags: review?(roc)
Attachment #332706 - Flags: review?(joshmoz)
Attachment #332706 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/84bbd1f88fac
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Component: General → Widget: BeOS
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Product: Firefox → Core
QA Contact: general → beos
Hardware: Macintosh → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Component: Widget: BeOS → Widget: Cocoa
QA Contact: beos → cocoa
Markus, please correct me when I'm wrong but it still doesn't work for me with the latest nightly build. Please see both attachments which show that the sheets are places above or below the toolbar.
Both can be seen with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080921021112 Minefield/3.1b1pre ID:20080921021112
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Funny. I'll back out when I have time to.
Status: REOPENED → ASSIGNED
Backed out.
OK, the difference in behaviour from the nightly build and my local build was caused by the fact that I wasn't building with the 10.4 SDK. When I build with the 10.4 SDK, I see the bug.

I'll go debug a little.
It looks like setContentBorderThickness is just buggy when building with the 10.4 SDK. I don't know what to do about this - Josh, do you have any ideas?
When this was in the nightly, I was getting a crash on start, since it was backed out the latest nightly loads fine. It's confusing since what the crash reporter is reporting, isn't what's in the patch (NSMinXEdge vs. NSMaxYEdge)

"Obj-C Exception data: NSInvalidArgumentException: setContentBorderThickness:forEdge: may not be called with NSMinXEdge"

I'm on Leopard PPC, could something be different in the compiling process? Here's a report on the crash server, http://crash-stats.mozilla.com/report/index/bcb1330c-886d-11dd-b393-001cc4e2bf68
There's probably nothing we can do here as long as we're building with the 10.4 SDK.
Somebody should try to create a reduced testcase and file a bug at Apple.
Assignee: mstange → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.9.1b1 → ---
Duplicate of this bug: 483057
Flags: wanted1.9.2?
Attached patch v2Splinter Review
Now that we're using the 10.5 SDK this should work glitch-free.
Assignee: nobody → mstange
Attachment #332706 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #411397 - Flags: review?(joshmoz)
Attachment #411397 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/90c81f1fb23d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
There is a gap now between the sheet and the collapsed toolbar. See bug 528830.
You need to log in before you can comment on or make changes to this bug.