403219 - Remove 2 obsolete <newserver.*> files, or other left-overs

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Serge Gautherie (:sgautherie)]

Email:
{{
Serge Gautherie wrote:
>
> I noticed that <newserver.dtd> and <newserver.properties> look useless actually:
> <http://mxr.mozilla.org/seamonkey/search?string=newserver&case=on&tree=seamonkey>

You are right, the code using those strings was removed when we worked on bug 327181.
Kai
}}

***

Kai, could you check bug 327181 in case there would be other obsoleted files to remove too ?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Stop packaging the 2 obsolete <newserver.*> files [Checkin: Comment 4]

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> > <http://mxr.mozilla.org/seamonkey/search?string=newserver&case=on&tree=seamonkey>

<http://mxr.mozilla.org/mozilla/search?string=newserver&case=on>
confirms this ;->

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 288016 [details] [diff] [review]
(Av1) Stop packaging the 2 obsolete <newserver.*> files
[Checkin: Comment 4]

r=kengert

That's ok. When we check this in, we should "cvs remove" the two mentioned files, too.

Comment 4

[Kai Engert (:KaiE:)]

fixed

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-SM) Stop packaging the 3 obsolete <*.xul> files [Checkin: Comment 7]

See bug 327181:
*Patch "Changes outside of PSM based on Patch v5" included these changes.
*"patch v7" said "... no longer contains the changes to extensions/help 
..."
*"Patch as checked in" said "... combines the two reviewed patches ..."
*But it missed 'extensions/help' actually :-(

*****

(In reply to comment #4)
> fixed

Kai,

1) There are other files to "cvs remove":
[
mozilla/ security/ manager/ pki/ resources/ content/

 	domainMismatch.js  	0  	Oct 4 11:31  	 
	domainMismatch.xul 	0 	Oct 4 11:31 	 
 	serverCertExpired.js  	0  	Oct 4 11:31  	 
	serverCertExpired.xul 	0 	Oct 4 11:31 	 
]


2) Then, could you check bug 327181 (again) in case any of these two issues would affect other files ?

Comment 6

[[e-mail]]

Comment on attachment 288412 [details] [diff] [review]
(Bv1-SM) Stop packaging the 3 obsolete <*.xul> files
[Checkin: Comment 7]

If there isn't a bug on adding help for the new SSL error pages, and removing the help pages for these dialogs, can you file one please?.

Comment 7

[Reed Loden [:reed]]

Checking in suite/common/helpSecurityOverlay.xul;
/cvsroot/mozilla/suite/common/helpSecurityOverlay.xul,v  <--  helpSecurityOverlay.xul
new revision: 1.3; previous revision: 1.2
done
Checking in suite/common/jar.mn;
/cvsroot/mozilla/suite/common/jar.mn,v  <--  jar.mn
new revision: 1.32; previous revision: 1.31
done

Comment 8

[Reed Loden [:reed]]

Removing security/manager/pki/resources/content/domainMismatch.js;
/cvsroot/mozilla/security/manager/pki/resources/content/domainMismatch.js,v  <--  domainMismatch.js
new revision: delete; previous revision: 1.16
done
Removing security/manager/pki/resources/content/domainMismatch.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/domainMismatch.xul,v  <--  domainMismatch.xul
new revision: delete; previous revision: 1.24
done
Removing security/manager/pki/resources/content/serverCertExpired.js;
/cvsroot/mozilla/security/manager/pki/resources/content/serverCertExpired.js,v  <--  serverCertExpired.js
new revision: delete; previous revision: 1.17
done
Removing security/manager/pki/resources/content/serverCertExpired.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/serverCertExpired.xul,v  <--  serverCertExpired.xul
new revision: delete; previous revision: 1.26
done

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> can you file one please?.

Done, as bug 403635.