403224 - Build spidermonkey with icc on macintel

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Robert Sayre]

icc could give us some good performance improvements on macintel. We should try it.

Comment 1

[(not currently active) Ted Mielczarek]

For the record, this requires icc 10.1, which requires Leopard.

Comment 2

[Robert Sayre]

Read some more docs on icc. We need to be careful that its runtime dependencies aren't too heavy. Looks like it installs some libs in /opt that it links against.

Comment 3

[Shawn Wilsher :sdwilsh]

Dependent on Bug 386840, or should that bug just be WONTFIX'd/INVALIDated?

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: fixes to build spidermonkey with icc [checked in]

This lets us build just spidermonkey with icc.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: mozconfig for a universal build with js-icc

Here's the mozconfig I used to make a Universal build with the x86 spidermonkey built with icc.

Comment 6

[(not currently active) Ted Mielczarek]

about bug 386840, that's still a valid bug, we're only building spidermonkey with ICC here, because it's pretty self-contained and C, not C++. It would be neat if we could build the entire app with ICC, but that's a bit more work.

Comment 7

[Damon Sicore (:damons)]

We have to make a decision *now* as to wether or not we are going to do this.

+'ing with P1 so a decision is made here.

Comment 8

[(not currently active) Ted Mielczarek]

Given shebs' latest comment on bug 421534 (bug 421534 comment 7), unless we have another week to spare before beta this looks like it isn't going to make it.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 309986 [details] [diff] [review]
fixes to build spidermonkey with icc [checked in]


Checked in except for the js/src bits, I'll attach a separate patch with that part.

Comment 10

[(not currently active) Ted Mielczarek]

Attachment: just the js/src bits [checked in]

Comment 11

[(not currently active) Ted Mielczarek]

We're not going to get bug 417045 done in time, so minusing this now. Whoever takes my checkin-needed, I think you're still ok to check that bit in, considering it was part of my original patch.

Comment 12

[Reed Loden [:reed]]

Checking in js/src/Makefile.in;
/cvsroot/mozilla/js/src/Makefile.in,v  <--  Makefile.in
new revision: 3.123; previous revision: 3.122
done

Comment 13

[Ed Morley [:emorley]]

The following added to both configure.ins contained a typo:
> AC_DEFINE_UNQUOTED(__ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED__,$_MACOSX_DEPLOYMENT_TARGET)

Since nothing broke with the typo, I'm going to remove those lines in bug 659997. If fixing the typo is preferred over removal, please let me know there.

Also, should this bug be resolved fixed?

Comment 14

[Gregory Szorc [:gps]]

I'm going to assert this nearly 6 year old bug is neither a P1 nor a current request.