Closed Bug 403224 Opened 12 years ago Closed 6 years ago

Build spidermonkey with icc on macintel

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: sayrer, Unassigned)

References

Details

Attachments

(3 files)

icc could give us some good performance improvements on macintel. We should try it.
For the record, this requires icc 10.1, which requires Leopard.
Read some more docs on icc. We need to be careful that its runtime dependencies aren't too heavy. Looks like it installs some libs in /opt that it links against.
Product: Toolkit → Core
Dependent on Bug 386840, or should that bug just be WONTFIX'd/INVALIDated?
Assignee: nobody → ted.mielczarek
Flags: blocking1.9?
Summary: Build with icc on macintel → Build spidermonkey with icc on macintel
This lets us build just spidermonkey with icc.
Attachment #309986 - Flags: review?(benjamin)
Here's the mozconfig I used to make a Universal build with the x86 spidermonkey built with icc.
about bug 386840, that's still a valid bug, we're only building spidermonkey with ICC here, because it's pretty self-contained and C, not C++. It would be neat if we could build the entire app with ICC, but that's a bit more work.
Priority: -- → P1
We have to make a decision *now* as to wether or not we are going to do this.

+'ing with P1 so a decision is made here.
Flags: blocking1.9? → blocking1.9+
Given shebs' latest comment on bug 421534 (bug 421534 comment 7), unless we have another week to spare before beta this looks like it isn't going to make it.
Attachment #309986 - Flags: review?(benjamin) → review+
Comment on attachment 309986 [details] [diff] [review]
fixes to build spidermonkey with icc [checked in]


Checked in except for the js/src bits, I'll attach a separate patch with that part.
Attachment #309986 - Attachment description: fixes to build spidermonkey with icc → fixes to build spidermonkey with icc [checked in]
We're not going to get bug 417045 done in time, so minusing this now. Whoever takes my checkin-needed, I think you're still ok to check that bit in, considering it was part of my original patch.
Assignee: ted.mielczarek → nobody
Flags: wanted-next+
Flags: blocking1.9-
Flags: blocking1.9+
Version: unspecified → Trunk
Checking in js/src/Makefile.in;
/cvsroot/mozilla/js/src/Makefile.in,v  <--  Makefile.in
new revision: 3.123; previous revision: 3.122
done
Attachment #310283 - Attachment description: just the js/src bits → just the js/src bits [checked in]
The following added to both configure.ins contained a typo:
> AC_DEFINE_UNQUOTED(__ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED__,$_MACOSX_DEPLOYMENT_TARGET)

Since nothing broke with the typo, I'm going to remove those lines in bug 659997. If fixing the typo is preferred over removal, please let me know there.

Also, should this bug be resolved fixed?
I'm going to assert this nearly 6 year old bug is neither a P1 nor a current request.
Status: NEW → RESOLVED
Closed: 6 years ago
Priority: P1 → --
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.