Closed
Bug 659997
Opened 14 years ago
Closed 13 years ago
Remove typo'd ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED define
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
1.83 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
Was added typo'd in bug 403224, so presumably not required: > AC_DEFINE_UNQUOTED(__ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED__,$_MACOSX_DEPLOYMENT_TARGET) http://mxr.mozilla.org/mozilla-central/search?string=MAC_OS_X_VERION_MIN_REQUIRED
Assignee | ||
Comment 1•14 years ago
|
||
Two line change. Thanks :-)
Attachment #535379 -
Flags: review?(ted.mielczarek)
Comment 3•13 years ago
|
||
Comment on attachment 535379 [details] [diff] [review] Remove define Review of attachment 535379 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #535379 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Only change is adding the patch author field, which hg missed off despite my hgrc; carrying forwards r+. Has passed try (comment 2); author & commit message filled out. Thanks to whomever checks it in :-)
Attachment #535379 -
Attachment is obsolete: true
Attachment #538095 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/972980426471
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Comment 6•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0 Is there any way to verify this? I looked in the files in the repo: http://hg.mozilla.org/mozilla-central/file/e87454393401 Is this enough to mark this as VERIFIED FIXED? Thanks!
Assignee | ||
Comment 7•13 years ago
|
||
For cleanup changes the answer to that is normally going to be that there is no way to verify apart from visual inspection. This is particularly the case for bugs filed under Core::Build Config - and even more so where no lines were added, only removed.
Comment 8•13 years ago
|
||
Marking this as VERIFIED FIXED based on Comment 7. Thanks ED!
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•