659997 - Remove typo'd ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED define

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

Was added typo'd in bug 403224, so presumably not required:

> AC_DEFINE_UNQUOTED(__ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED__,$_MACOSX_DEPLOYMENT_TARGET)

http://mxr.mozilla.org/mozilla-central/search?string=MAC_OS_X_VERION_MIN_REQUIRED

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove define

Two line change.

Thanks :-)

Comment 2

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=814ab5d45c97

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 535379 [details] [diff] [review]
Remove define

Review of attachment 535379 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Ed Morley [:emorley]]

Attachment: Remove define

Only change is adding the patch author field, which hg missed off despite my hgrc; carrying forwards r+.

Has passed try (comment 2); author & commit message filled out.
Thanks to whomever checks it in :-)

Comment 5

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/972980426471

Comment 6

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way to verify this?

I looked in the files in the repo:
http://hg.mozilla.org/mozilla-central/file/e87454393401

Is this enough to mark this as VERIFIED FIXED?

Thanks!

Comment 7

[Ed Morley [:emorley]]

For cleanup changes the answer to that is normally going to be that there is no way to verify apart from visual inspection. This is particularly the case for bugs filed under Core::Build Config - and even more so where no lines were added, only removed.

Comment 8

[Simona Badau, Desktop QA]

Marking this as VERIFIED FIXED based on Comment 7.

Thanks ED!