Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove typo'd ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED define

VERIFIED FIXED in mozilla7

Status

()

Core
Build Config
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Was added typo'd in bug 403224, so presumably not required:

> AC_DEFINE_UNQUOTED(__ENVIRONMENT_MAC_OS_X_VERION_MIN_REQUIRED__,$_MACOSX_DEPLOYMENT_TARGET)

http://mxr.mozilla.org/mozilla-central/search?string=MAC_OS_X_VERION_MIN_REQUIRED
(Assignee)

Comment 1

6 years ago
Created attachment 535379 [details] [diff] [review]
Remove define

Two line change.

Thanks :-)
Attachment #535379 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=814ab5d45c97
Comment on attachment 535379 [details] [diff] [review]
Remove define

Review of attachment 535379 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535379 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 538095 [details] [diff] [review]
Remove define

Only change is adding the patch author field, which hg missed off despite my hgrc; carrying forwards r+.

Has passed try (comment 2); author & commit message filled out.
Thanks to whomever checks it in :-)
Attachment #535379 - Attachment is obsolete: true
Attachment #538095 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/972980426471
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way to verify this?

I looked in the files in the repo:
http://hg.mozilla.org/mozilla-central/file/e87454393401

Is this enough to mark this as VERIFIED FIXED?

Thanks!
(Assignee)

Comment 7

6 years ago
For cleanup changes the answer to that is normally going to be that there is no way to verify apart from visual inspection. This is particularly the case for bugs filed under Core::Build Config - and even more so where no lines were added, only removed.
Marking this as VERIFIED FIXED based on Comment 7.

Thanks ED!
Status: RESOLVED → VERIFIED

Updated

6 years ago
Blocks: 705532
You need to log in before you can comment on or make changes to this bug.