Cursor does not always change to appropriate pointer after using scroll buttons/slider.

NEW
Unassigned

Status

Core Graveyard
Widget: BeOS
10 years ago
2 years ago

People

(Reporter: Doug Shelton, Unassigned)

Tracking

({fixed1.8.1.12})

Trunk
x86
BeOS
fixed1.8.1.12

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.10pre) Gecko/20071105 BonEcho/2.0.0.10pre
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.10pre) Gecko/20071105 BonEcho/2.0.0.10pre

A conditional in nsWindow.cpp attempts to avoid unnecessary cursor changes by looking at mCursor.  Unfortunately, mCursor does not always reflect the current cursor because scrollbars and grippies change it, too.  This same fix has already been implemented in Windows code.

Reproducible: Always

Steps to Reproduce:
1.  Click and drag scroll button, column width bar or window resize grippy.
2.  Unclick after drag, then move cursor over a link or other item in window body.
Actual Results:  
Cursor stays as resize cursor.

Expected Results:  
Cursor changes to reflect appropriate cursor type for selected item (i.e., link.)
(Reporter)

Comment 1

10 years ago
Created attachment 288220 [details] [diff] [review]
Cursor fix for 1.8 branch
Assignee: general → doug
Status: NEW → ASSIGNED
(Reporter)

Comment 2

10 years ago
Created attachment 288221 [details] [diff] [review]
Cursor fix for trunk
(Reporter)

Updated

10 years ago
Attachment #288220 - Flags: review?(sergei_d)
(Reporter)

Updated

10 years ago
Attachment #288221 - Flags: review?(sergei_d)
Attachment #288221 - Flags: approval1.8.1.10?
(Reporter)

Comment 3

10 years ago
These are BeOS-only changes and will not impact other platforms.  This fix is already present in the MS Windows nsWindow.cpp code.

Comment 4

10 years ago
Comment on attachment 288220 [details] [diff] [review]
Cursor fix for 1.8 branch

r=sergei_d
Attachment #288220 - Flags: review?(sergei_d) → review+

Comment 5

10 years ago
Comment on attachment 288221 [details] [diff] [review]
Cursor fix for trunk

r=sergei_d for code change.
But are you sure about comment? Bug 403405 is:
"Proposal: new access key "backspace" to close current mail and return into mail"

Updated

10 years ago
Attachment #288221 - Flags: review?(sergei_d) → review+
(Reporter)

Updated

10 years ago
Attachment #288220 - Flags: approval1.8.1.10?
(Reporter)

Updated

10 years ago
Attachment #288221 - Flags: approval1.8.1.10?
(Reporter)

Comment 6

10 years ago
Created attachment 288319 [details] [diff] [review]
Cursor fix for branch with correct bug reference in comments
[Checkin: Comment 12]
Attachment #288220 - Attachment is obsolete: true
Attachment #288319 - Flags: review?(sergei_d)
Attachment #288319 - Flags: approval1.8.1.10?
Attachment #288220 - Flags: approval1.8.1.10?
(Reporter)

Comment 7

10 years ago
Created attachment 288320 [details] [diff] [review]
Cursor fix for trunk with correct bug reference in comments

thanks for the catch, Sergei.
Attachment #288320 - Flags: review?(sergei_d)
(Reporter)

Updated

10 years ago
Attachment #288221 - Attachment is obsolete: true
(Reporter)

Comment 8

10 years ago
Tested in Thunderbird branch build, also.  Fixes problem there, too.

Updated

10 years ago
Attachment #288319 - Flags: review?(sergei_d) → review+

Updated

10 years ago
Attachment #288320 - Flags: review?(sergei_d) → review+
Comment on attachment 288319 [details] [diff] [review]
Cursor fix for branch with correct bug reference in comments
[Checkin: Comment 12]

approved for 1.8.1.10, but might end up being 1.8.1.11 if you can't land soon.
Attachment #288319 - Flags: approval1.8.1.10? → approval1.8.1.10+
(Reporter)

Comment 10

10 years ago
Thanks Daniel!  I'll try to land it this evening, if I can get my CVS login working.  Else, may need to wait for Sergei.
The branch for 1.8.0.10 has been cut, so this'll be in the next release from the 1.8 branch.

Comment 12

10 years ago
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.28; previous revision: 1.91.4.27
done

Doug, let me know when trunk is open
Keywords: fixed1.8.1.11
Doug,
Are you still working on this ?
(Reporter)

Comment 14

9 years ago
Serge, this is fixed on branch but I don't believe we ever landed it in the trunk.  Sergei D, do you happen to know if this is in the trunk?

Comment 15

9 years ago
(In reply to comment #14)
> Serge, this is fixed on branch but I don't believe we ever landed it in the
> trunk.  Sergei D, do you happen to know if this is in the trunk?
> 

IIRC I didn't land it to tha trunk, as at time trunk was permanently closed or restricted to "specially" approved patches - so we didn't bother with that. But I can look at trunk code and prepare that patch for it, if now checkin policy is more safe:)
Attachment #288319 - Attachment description: Cursor fix for branch with correct bug reference in comments → Cursor fix for branch with correct bug reference in comments [Checkin: Comment 12]
Right now, "The tree is in lockdown for RC2, and because of NetApp woes".
But, when it reopens, I think BeOS specific patch can land without approval.
If in doubt, request "approval1.9"...
Assignee: doug → nobody
Status: ASSIGNED → NEW
Component: General → Widget: BeOS
Product: Mozilla Application Suite → Core
QA Contact: general → beos
Version: unspecified → Trunk
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.