Closed Bug 403472 Opened 17 years ago Closed 17 years ago

redundant separator in context menu if a space is selected in frameset

Categories

(Firefox :: Menus, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 303898

People

(Reporter: bugzilla, Unassigned)

References

()

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007111104 Minefield/3.0b2pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007111104 Minefield/3.0b2pre When you select a space character on a website with a frameset, the context menu incorrectly shows two adjoining separators above the "This Frame ->" item. This problem doesn't occur on a page without a frameset Reproducible: Always Steps to Reproduce: 1. Go to the URL 2. Select a <space> 3. Right click for the context menu Actual Results: Two separators Expected Results: One separator
Attached patch FixSplinter Review
This small fix seems to solve the problem. I'm new to this, so I'm not sure what the correct flags are, so sorry for the bugspam if incorrect.
Attachment #288321 - Flags: review+
Attachment #288321 - Flags: approval1.9?
Attachment #288321 - Flags: review+ → review?(gavin.sharp)
Comment on attachment 288321 [details] [diff] [review] Fix clearing approval until gavin reviews...
Attachment #288321 - Flags: approval1.9?
Comment on attachment 288321 [details] [diff] [review] Fix This would regress bug 280284.
Attachment #288321 - Flags: review?(gavin.sharp) → review-
Thanks for taking the time to report this and prepare the patch, Arjan. It looks like it's already been reported as bug 303898, perhaps you could take a look at the patch that's attached there and try it out for yourself?
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: