40357 - Filter UI: MoveToFolder dropdown shouldn't offer news accts.

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P2)

Description

[laurel]

Using may23 m16 commercial build

The dropdown to select destination for the Move To Folder action shouldn't offer
news accounts.  Newsgroups would be an invalid target for a move action.

1.  From mail window, launch message filters (Edit|Message Filters).
2.  Click New button.
3.  In the Action section of the dialog, set action to Move to Folder (which is
the default) then pulldown the destination menu to see the choices.

Result:  Move to Folder destination dropdown has news accounts/newsgroups in the
list when it should not.  News servers/groups are not valid move destinations.

Comment 1

[Alec Flett]

again, need to filter on folders that can accept messages.

Comment 2

[scottputterman]

mass moving to M18 and adding nsbeta3 keyword

Comment 3

[Alec Flett]

I have the fix in hand for this, which I did while working on another filter bug 
a few weeks ago (but I forgot all about it until now)
Attaching a proposed fix and renominating for nsbeta3
(the same patch fixes this and bug 40358, they're basically the same fix)

Comment 4

[Alec Flett]

Attachment: filter out folders which cannot accept messages (such as servers, news, etc)

Comment 5

[laurel]

removed Future target milestone to aid renomination for beta3

Comment 6

[lchiang]

+ per mail triage

Comment 7

[Alec Flett]

oops, forgot to add the appropriate people for a review - bienvenu because it's 
filter stuff, sspitzer because it's folder dropdown stuff... anyone?

Comment 8

[David :Bienvenu]

r=bienvenu

Comment 9

[Alec Flett]

fix is in, thanks david

Comment 10

[laurel]

OK using aug31 commercial build linux rh6.0, mac OS 9.0 and NT 4.0.

News or account/server levels not able to be chosen from target folder dropdown.
HOWEVER, default mail account/server level shows as default and any existing
filter will display the default mail server when editing (see bug 50970).

Comment 11

[laurel]

Using sep13 commercial build, this is broken again; you can select Local Folders
or server/account level. 

Break is maybe related to fix for bug 50970 or bug 42534?

Comment 12

[laurel]

*** Bug 40358 has been marked as a duplicate of this bug. ***

Comment 13

[Alec Flett]

CC'ing dimi - I think its related. We may have hit a bug in the template code.

dimi - what's the new bug that got filed against waterson/rjc? we may need that 
to be fixed sooner rather than later to get both this and 50970

Comment 14

[Dimi Shahbaz]

Alec, I added a rule to set server menuitems hidden, and commented out the
seperator.  Sub-folders of folders still work fine, as they are handled by the
following rule.
If I comment out the rule's contents, or comment out the new "hidden" menuitem,
bug 50970 creeps back in.  Very strange.  It is probably related to the bug I
haven't yet filed against waterson. :)  I'll file it today.
patch coming.

Comment 15

[Dimi Shahbaz]

Attachment: black magic fix.

Comment 16

[Phil Peterson]

PDT reviewing P2 bugs. Not clear what the user impact is to this problem, but if 
your patch is good, check it in before we start throwing P2 bugs overboard.

Comment 17

[Alec Flett]

give to dimi, he has a fix

Comment 18

[Dimi Shahbaz]

Checked in fix.

Comment 19

[laurel]

OK using:
2000-09-15-08 commercial build linux rh6.0
2000-09-15-05 commercial build NT 4.0
2000-09-15-04 commercial build mac OS 9.0