403659 - autocomplete dropdown has shaded bar / is not big enough after 118312

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P4)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 Using a fresh profile in a recent Linux trunk build (after 11-12)...
  1. Go to http://www.google.com/
  2. Type "mozilla" into Google's search box. (or some word that has no autocomplete options).  No autocomplete options should appear.
  3. Press the 'enter' key to perform the search.
  4. Go back to the main google page at http://www.google.com/
  5. Start typing "mozilla" into Google's search box, and watch the autocomplete dropdown that appears.

Expected Results:
 'mozilla' should be visible in the autocomplete dropdown.

Actual Results:
  The dropdown has a shaded bar above the text, pushing the text out of view.  You can barely see the top ends of the taller letters.

If you perform multiple searches that start with the same substring (e.g. 'mozilla' 'moon' 'mountain'), then the autocomplete dropdown will get bigger, but the last entry in the list is always just out of view.

Comment 1

[Tuukka Tolvanen (sp3000)]

Attachment: screenshot of location autocomplete with single result

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of google w/ single result

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of google w/ two results

Comment 4

[Sylvain Pasche]

This is rather a regression of bug 118312. See bug 118312 comment 57

Comment 5

[Teune van Steeg]

Attachment: simple fix

We should not expect a sort arrow in an autocomplete popup menu.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 288553 [details] [diff] [review]
simple fix

I haven't tested this, r=me assuming you have :)

Comment 7

[Reed Loden [:reed]]

Comment on attachment 288553 [details] [diff] [review]
simple fix

Simple CSS fix to fix a bad UI issue on Linux.

Comment 8

[Hideo Oshima]

(In reply to comment #5)
> Created an attachment (id=288553) [details]
> simple fix
> 
> We should not expect a sort arrow in an autocomplete popup menu.
 
I tested the patch and it looks good.

Comment 9

[Reed Loden [:reed]]

Checking in toolkit/themes/winstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.21; previous revision: 1.20
done

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2 and the testcase 

- > Verified