403701 - Create pre-built Talkback packages for Firefox/Thunderbird 2.x

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

We need to create pre-built Talkback packages for Firefox/Thunderbird on the 2.x branch. 

The tinderbox infrastructure already exists to accommodate this, as we are already doing this for community products (Camino, Sunbird). Due to CVS access restrictions it is soon going to be easier/better for us to do this for MoCo products as well.

Not going to bother with 1.5.0.x, since Thunderbird is the only potential beneficiary there, and there will be at most 1 more maintenance release on that branch. However, since the final Tb 1.5.0.14 release will still require Talkback, this bug is blocked on that release because we can't obsolete the old cltbld ssh keys until that release is done, i.e. cltbld will still need access to the Talkback repo.

Comment 1

[Chris Cooper [:coop] (he/him)]

Planning to get these built tomorrow. This will hopefully allow us to finish off bug 399848 (role keys), at which point I can proceed with bug 387721 (password updates) and simply expire the cltbld key rather than creating a new one.

Comment 2

[Chris Cooper [:coop] (he/him)]

I have packages built for Firefox and Thunderbird now. I'll be testing them out with the necessary config changes to the Thunderbird branch tinderboxes (less impact than Firefox) tomorrow morning EST (Feb 7th).

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Use prebuilt/pre-packaged talkback for Thunderbird [checked in]

I've put the Talkback packages under /builds/tinderbox since we'll need to share them between the nightly and release build trees. 

Release configs will be a separate patch once nightlies are working for both Firefox and Thunderbird.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 301930 [details] [diff] [review]
Use prebuilt/pre-packaged talkback for Thunderbird [checked in]

r+. Maybe comment out/remove the $MofoRoot declarations too ?

Comment 5

[Chris Cooper [:coop] (he/him)]

$MofoRoot declarations removed.

Mac and Linux appear to have built fine, but Windows is broken. I'm
investigating this now.

Comment 6

[Chris Cooper [:coop] (he/him)]

Windows is working now too. I'll get a patch together for the Firefox and release configs tomorrow.

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: Use prebuilt/pre-packaged talkback for Firefox [checked in]

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 302129 [details] [diff] [review]
Use prebuilt/pre-packaged talkback for Firefox [checked in]

Looks good, r+.

Have you thought about the release and staging machines ? Presume the plan to use this package for releases too.

Comment 9

[Chris Cooper [:coop] (he/him)]

(In reply to comment #8)
> Have you thought about the release and staging machines ? Presume the plan to
> use this package for releases too.
 
Yeah, I'm working up that patch now.

Comment 10

[Chris Cooper [:coop] (he/him)]

Attachment: Use prebuilt/pre-packaged talkback for Firefox/Thunderbird releases [checked in]

I've installed the Talkback packages on the staging and production slaves, and I've made the necessary modifications to the fullsoft/Makefile.in file in the staging packages to point to staging-build-console instead of talkback-upload.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 302156 [details] [diff] [review]
Use prebuilt/pre-packaged talkback for Firefox/Thunderbird releases [checked in]

looks good, r+

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #10)
> Created an attachment (id=302156) [details]
> se prebuilt/pre-packaged talkback for Firefox/Thunderbird releases
> 
> I've installed the Talkback packages on the staging and production slaves, and
> I've made the necessary modifications to the fullsoft/Makefile.in file in the
> staging packages to point to staging-build-console instead of talkback-upload.

Did I get the wiki change right ?
http://wiki.mozilla.org/index.php?title=Build%3ARelease_Automation&diff=83227&oldid=81136

Comment 13

[Chris Cooper [:coop] (he/him)]

(In reply to comment #12)
 
> Did I get the wiki change right ?
> http://wiki.mozilla.org/index.php?title=Build%3ARelease_Automation&diff=83227&oldid=81136
> 

I made it slightly more specific, but otherwise good.

Comment 14

[Chris Cooper [:coop] (he/him)]

What's left here? Updating the cvs mirror on the staging master? Anything else?

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

I think we just need a followup bug for the release automation, since there's no need to tag the Talkback source. 

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

See bug 419800 #comment 4 for a problem pushing symbols to wrong dir on talkback-upload. 

Comment 17

[Phil Ringnalda (:philor)]

Judging by the timing, I'd guess this is the cause of bug 419735, too.

Comment 18

[Dave Miller [:justdave]]

This must not block bug 399848, since that's resolved already.

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

This did block 399848. We only reopened this to tweak the Talkback packages - see comment #16.

Comment 20

[Chris Cooper [:coop] (he/him)]

Just to verify, this is only happening for Thunderbird 2, correct?

Comment 21

[Nick Thomas [:nthomas] (UTC+12)]

Looks like it's Firefox as well. From today's win32 nightly:

Making /home/symbols/symbols/MozillaOrg/FirefoxTrunk/Win32 on the remote host...

Comment 22

[Chris Cooper [:coop] (he/him)]

Built new packages with the right FC_VERSION, checked them into CVS, and got them onto the right 1.8 machines (including the new production servers).