40380 - Filter/Search UI: Date criteria don't work

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P3)

Description

[laurel]

Using may23 m16 commercial build

The filter rules date criteria value field is currently a plain text field. It
should have some kind of date control widget. 

The date value field should have these properties:
1.  default to current date
2.  should default to a date format, with separators for day,month and year.
3.  should allow user to type/edit value for day, month or year.
4.  should not allow incorrect date to be typed in, i.e. no number out of range
for its focused field and only numbers, no text.
5.  should have increase/decrease control such as up/down arrow widget
6.  increase decrease control should work on the day,month,year portions of the
date field separately based on what portion has cursor focus
7.  should increase or decrease only within valid range for the day, month or
year, i.e. days = 1-31 months = 1-12 years = valid (4digit?) year format

Comment 1

[Alec Flett]

I need to check in the datepicker...argh

Comment 2

[scottputterman]

mass moving to M18 and adding nsbeta3 keyword

Comment 3

[laurel]

QA Note: also applies for Search messages ui. Verify both when fixed.

Comment 4

[laurel]

When a date filter is migrated from 4.x, the date is not shown in the filter ui
at all.  I assume because we have no format to translate it to. 

Do we want to worry about putting something in the ui for beta2 or pre-beta3?

Comment 5

[Alec Flett]

It's too much work for beta2, but definately for beta3.

Comment 6

[selmer (gone)]

Adding mail4 triage nomination keyword.

Comment 7

[selmer (gone)]

A minimal fix would be to describe the required format in the affected dialogs. 
 If you want to get the datepicker into beta3, please come explain why that's 
easy and safe.

Comment 8

[lchiang]

+ per mail triage for what Steve suggested above.

Comment 9

[robinf]

Adding myself to cc: list.

Comment 10

[lchiang]

second pass: - per mail triage

Comment 11

[robinf]

What's the required date format? I'll add this info to the online Help. Thanks.

Comment 12

[laurel]

Alec, what's the status of your tweak for (any) date format to work? Please
comment soon...

Comment 13

[laurel]

Last I spoke to alec, the date field has still not been tweaked to accept any
format... He indicated the date criteria option may need to be removed from the
search/filter ui if no fix is implemented by RTM.

Let me know if we need a separate bug to track the removal of date as a
choice...

Comment 14

[Alec Flett]

this weekend (i.e. within the last 24 hours or so) I did what I think is a 
working tweak. I have to play with it a bit more. I think we should leave it 
as-is for nsbeta3 and fix it for rtm, assuming my 4 line tweak really does make 
it start working.

Comment 15

[laurel]

Once again we're getting very close to another (THE) deadline...

For the final release record, going from Alec's last comments about RTM:
Will we tweak so at least one date format works, forget about this and leave it
as is, or remove date from criteria listing?

Comment 16

[scottputterman]

Sorry for the extra mail. Removing mail4 keyword.

Comment 17

[Gervase Markham [:gerv]]

It seems unclear to me whether this bug requires either of a "developer" or 
"user" release note for Netscape 6 RTM. If anyone feels it does, can they please 
draft one and then nominate with the relnote-user or relnote-devel strings in 
the Status Whiteboard.

Thanks :-)

Gerv

Comment 18

[Alec Flett]

reassigning my filter bugs to gayatrib..

Comment 19

[laurel]

*** Bug 59481 has been marked as a duplicate of this bug. ***

Comment 20

[laurel]

*** Bug 59481 has been marked as a duplicate of this bug. ***

Comment 21

[scottputterman]

marking nsbeta1- and moving to future milestone.  I don't know when this will
get done.

Comment 22

[laurel]

*** Bug 81649 has been marked as a duplicate of this bug. ***

Comment 23

[(not reading, please use [e-mail] instead)]

moving this back onto the radar.  0.9.2

Comment 24

[scottputterman]

moving to 0.9.3

Comment 25

[(not reading, please use [e-mail] instead)]

I'll attach a screen shot of the 4.x windows date picker.

Comment 26

[(not reading, please use [e-mail] instead)]

Attachment: 4.x picker

Comment 27

[timeless]

Attachment: icq date picker

Comment 28

[timeless]

Attachment: w2k date picker

Comment 29

[Håkan Waara]

No timeless, we aren't gonna implement anything that advanced.

Comment 30

[timeless]

ICQ2000b's date picker can be seen when you create a reminder and want to pick 
a date. W2k's date picker can be seen when you search for files or folders by 
date between [click dropdown button].

The w2k picker is part of the system so other apps may use it too.  Clicking 
on the year in the w2k picker makes the year an editable spincontrol.  Clicking 
on the month gives a context menu of the twelve months.

A control like the w2k one would probably be a nice addition, and having the 
drop down button replace the nc4 spin button would be an overal win.

Comment 31

[(not reading, please use [e-mail] instead)]

good news, I've got the search / date filters working again.

1) loading / saving date filters (including migrated 4.x filters) works
2) date based searches work
4) date based filters work

right now, my "date" picker is a xul text box that only works when you enter
"d/m/yyyy"

but I've added it as another card in the search value deck, so it can now be
replaced by a more advanced widget if someone has the interest and cycles to fix
it.

I'll attach a patch.

Comment 32

[(not reading, please use [e-mail] instead)]

Attachment: patch (contains some extra cruft), but it gets us going.

Comment 33

[(not reading, please use [e-mail] instead)]

Attachment: patch, with no cruft.

Comment 34

[(not reading, please use [e-mail] instead)]

I'm now going to see if I can get date terms to come up with the current date
(in the d/m/yyyy format).

this is useful, and it will help users have a clue what format to enter dates
in. (until we have a date picker.)

Comment 35

[(not reading, please use [e-mail] instead)]

Attachment: get date working, and preflight date terms to today's date

Comment 36

[timeless]

r=timeless

Comment 37

[(not reading, please use [e-mail] instead)]

fixed.

I'll open a new bug on implementing a better date picker.

Comment 38

[(not reading, please use [e-mail] instead)]

original bug spun off to bug #90289

Comment 39

[laurel]

*** Bug 92825 has been marked as a duplicate of this bug. ***

Comment 40

[laurel]

Using aug10 commercial trunk build: linux rh6.2, mac OS 9.0, win98.
Date searching, filtering generally work OK for POP and IMAP using the basic fix
(no widget -- that's being implemented with bug 90289/bug 92174). 

Criteria is now basically working.  
Any problems with specific date searches/filters will be logged separately.