404096 - For windows that don't have @titlebarcolor, draw titlebar background state if needed

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[Colin Barrett [:cbarrett]]

We should check the background state of the window when we draw the titlebar pattern. On Tiger it should be a pinstripe pattern and on Leopard it should be a lighter gradient.

This is a technically a regression for XUL consumers who don't specify the titlebarcolor attribute, so it really needs make it in for Firefox 3. Doesn't need to be right away though.

Comment 1

[Josh Aas]

I think I already fixed this, we could use a little XUL test case.

Comment 2

[Colin Barrett [:cbarrett]]

This isn't fixed. I just did a pull.

What should happen on Tiger: When a normal window is in the background, it should draw with a pinstriped pattern in the titlebar. On Leopard, it should be a lighter gray.

That's what this bug is for.

Comment 3

[Josh Aas]

How do you you know it is not fixed? We need a test case here in this bug.

Comment 4

[Colin Barrett [:cbarrett]]

Attachment: testcase, run with -chrome

Lauch this by running it with the -chrome command line argument.

It doesn't include any external CSS, which is why it behaves as it does.

STR:

1. Launch above testcase as the argument to the -chrome commandline flag
2. Focus the app's window
3. Focus another application

Expected results:

Titlebar will change appearance (on Tiger to a pinstriped background, on Leopard to a lighter than normal gray).

Actual results:

Titlebar's appearance does not change.

Comment 5

[Colin Barrett [:cbarrett]]

Attachment: fix v1.0

Comment 6

[Colin Barrett [:cbarrett]]

Checking in widget/src/cocoa/nsCocoaWindow.mm;
/cvsroot/mozilla/widget/src/cocoa/nsCocoaWindow.mm,v  <--  nsCocoaWindow.mm
new revision: 1.123; previous revision: 1.122
done