All users were logged out of Bugzilla on October 13th, 2018

Bottom border of title bar on Leopard does not dim properly

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: cbarrett, Assigned: cbarrett)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 291774 [details] [diff] [review]
fix v1.0

STR:
 - Focus a Firefox window.
 - Click on another window.

Expected results:
 Titlebar and bottom border of it dim

Actual results:
 Titlebar dims, bottom border does not.

This is my fault, I somehow missed writing this code for bug 404096, and the testcase I put in the bug for QA didn't say "and make sure it matches TextEdit" or anything.

Patch attached, has some extra comment fixes as well.
Attachment #291774 - Flags: review?(joshmoz)

Updated

11 years ago
Attachment #291774 - Flags: superreview?(roc)
Attachment #291774 - Flags: review?(joshmoz)
Attachment #291774 - Flags: review+
Attachment #291774 - Flags: superreview?(roc) → superreview+

Updated

11 years ago
Flags: blocking1.9+
Priority: -- → P3
(Assignee)

Comment 1

11 years ago
Comment on attachment 291774 [details] [diff] [review]
fix v1.0

This is a small patch to fix a small visual glitch in the titlebar. It certainly annoys me when using nightlies that exhibit this behavior.

Low risk.
Attachment #291774 - Flags: approvalM10?
Comment on attachment 291774 [details] [diff] [review]
fix v1.0


We'll get this in the next release.  aM10-.
Attachment #291774 - Flags: approvalM10? → approvalM10-
(Assignee)

Comment 3

11 years ago
Checking in widget/src/cocoa/nsCocoaWindow.mm;
/cvsroot/mozilla/widget/src/cocoa/nsCocoaWindow.mm,v  <--  nsCocoaWindow.mm
new revision: 1.126; previous revision: 1.125
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.