Closed Bug 40444 Opened 25 years ago Closed 25 years ago

Toolbar buttons need user-focus: none CSS

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: bugzilla, Assigned: bugs)

References

Details

(Keywords: regression, smoketest, Whiteboard: [nsbeta2+][dogfood-])

saw this using opt comm bits 2000.05.24.08 on linux (haven't gotten to the other platforms yet). using the menu equivalents *does* work, however. 1. open a Composer window. 2. type some text and select it. 3. click on the bold, italic or underline buttons on the toolbar. result: none of the styles are applied. no console messages, either. workaround: use the style choices from the Format menu.
aha, since i noticed that the Spell button doesn't work when clicking its button, i tried accessing it from the menu, and lo! the spellchecker does work if you use its menu equivalent. updated summary.
Summary: style buttons on toolbar don't work → items in toolbars don't work
assigning this to hyatt, it seems to be an event problem
Assignee: beppe → hyatt
Target Milestone: --- → M16
*** Bug 40443 has been marked as a duplicate of this bug. ***
affects all/all. (tested w/today's opt comm bits on mac and winnt.)
Severity: major → critical
OS: Linux → All
Hardware: PC → All
Putting on [nsbeta2+][dogfood-] radar. Does not need a fix ASAP for daily work due to workaround, but we should fix this for beta2.
Whiteboard: [nsbeta2+][dogfood-]
Mail and mail compose toolbars work. Thus my guess is that this is some weirdness in the composer xul/js.
Summary: items in toolbars don't work → Items in composer toolbars don't work
This really has to be a blocker. It's serious enough to interrupt workflow.
Severity: critical → blocker
top.document.commandDispatcher.getControllerForCommand(command) is failing to find a controller to handle the editor commands. This sounds like some kind of toolbar focus issue.
Confirmed. Calling window.content.focus() before the goDoCommand() makes it work.
This is ben's fault. He checked in, in xul.css button { user-focus: normal; } yesterday. Backing this out fixes the problem.
Assignee: hyatt → ben
Simon, can you back this out for now?
I backed out the above CSS. Now, ben needs to put this back in, then add style to all kinds of toolbar buttons so that they don't steal focus.
Severity: blocker → normal
Summary: Items in composer toolbars don't work → Toolbar buttons need user-focus: none CSS
Target Milestone: M16 → M17
Move to M18 target milestone.
Target Milestone: M17 → M18
ive got this mostly cleaned up, waiting on some feedback from a few people and it shoudl be in shortly.
Not holding the tree for this.
Hmmmm ... this looks like it works now.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
verified in 7/7 build.
Status: RESOLVED → VERIFIED
Adding keyword to bugs which already show a nsbeta2 triage value in the status whiteboard so the queries don't get screwed up.
Keywords: nsbeta2
You need to log in before you can comment on or make changes to this bug.