Closed Bug 404493 Opened 13 years ago Closed 13 years ago

Native GTK style for arrows

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: micmon, Assigned: ventnor.bugzilla)

References

Details

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111904 Minefield/3.0b2pre

The treeview now draws the sort arrows using the native GTK theme. But there are other places were the old bitmap arrows are still used:

## Menus
## Toolbars

Those should also be updated to use the native style arrows.

Reproducible: Always
This shows the FF3 and the native arrows in menus and toolbars.
Component: OS Integration → Widget: Gtk
Product: Firefox → Core
QA Contact: os.integration → gtk
Version: unspecified → Trunk
Attached patch For menus (obsolete) — Splinter Review
Heh, it turns out there is a -moz-appearance value for menu arrows all along. This patch will use it taking a similar code approach as GTK itself does.

I'll have to look into toolbar button arrows later.
Assignee: nobody → ventnor.bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #290321 - Flags: superreview?(roc)
Attachment #290321 - Flags: review?(roc)
Attachment #290321 - Flags: superreview?(roc)
Attachment #290321 - Flags: superreview+
Attachment #290321 - Flags: review?(roc)
Attachment #290321 - Flags: review+
Attachment #290321 - Flags: approval1.9?
May I suggest a style size of 1ex for the menu arrows (or something like that), so that the arrows will grow when the font size grows (like with native menu arrows)?
Attached patch For menus 1.01Splinter Review
Sounds good to me.
Attachment #290341 - Flags: approval1.9?
Attachment #290321 - Attachment is obsolete: true
Attachment #290321 - Flags: approval1.9?
Attachment #290341 - Attachment description: Patch 1.01 → For menus 1.01
Comment on attachment 290341 [details] [diff] [review]
For menus 1.01

a=beltzner for drivers
Attachment #290341 - Flags: approval1.9? → approval1.9+
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.42; previous revision: 1.41
done
Checking in widget/src/gtk2/gtkdrawing.h;
/cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v  <--  gtkdrawing.h
new revision: 1.37; previous revision: 1.36
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.114; previous revision: 1.113
done
Checking in toolkit/themes/gnomestripe/global/menu.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menu.css,v  <--  menu.css
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
I've just noticed that the down-arrow in the History sidebar's View button is still non-native: should I reopen this bug, file a new bug blocking this one, or perform an elaborate dance in an effort to appease the gods of natively-drawn arrows?
(In reply to comment #7)
> I've just noticed that the down-arrow in the History sidebar's View button is
> still non-native: should I reopen this bug, file a new bug blocking this one,
> or perform an elaborate dance in an effort to appease the gods of
> natively-drawn arrows?
> 

Just have a look at Bug 416818 and hope Bug 416868 lands soon :)
Me again: the progressive disclosure arrows in the star dialogue are also non-native. New bug?
Depends on: 420287
Filed one anyway: bug 420287
You need to log in before you can comment on or make changes to this bug.