405094 - Tooltip doesn't disappear anymore when hovering over it

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, to reproduce:
- Hover over the green div.
- Hover over the tooltip that has appeared

Expected result:
Tooltip should disappear when hovering over the tooltip.

Actual result:
Tooltip doesn't disappear anymore.

This regressed between Nov 15 22:20 and Nov 16 01:05 (thanks to hourly builds):
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1195192920&maxdate=1195201859
So this is a regression from bug 396869.

Comment 1

[Ginn Chen]

The call to NotifyMouseOut is from NotifyMouseOver.
So the checking of spurious event is fooled.

Comment 2

[Ginn Chen]

Attachment: patch

Thanks for catching this!

Comment 3

[Ginn Chen]

Attachment: patch v2

roc,

I've a concern about the kidESM->NotifyMouseOut, the kidESM may have another mLastMouseOverFrame which doesn't have the same top widget with aEvent->widget.
It could be a problem, although I don't have a testcase to prove it.

I think maybe we should move the checking outside NotifyMouseOut().

Do you think it is better?

BTW: I cleaned extra whitespaces I introduced to nsContentUtils.cpp in this patch.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 290502 [details] [diff] [review]
patch v2

a=beltzner for drivers

(does this fix the orphan tooltip on mac thing as well?)

Comment 5

[Reed Loden [:reed]]

Ginn, can you commit this, please?

Comment 6

[Ginn Chen]

Committed.

This patch is to fix a regression.

I know nothing about orphan tooltip.

Comment 7

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120405 Minefield/3.0b2pre