405105 - Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver] when closing the pageInfo window.

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Philip Chee]

Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]

Steps to reproduce:
1. Navigate to about:blank.
2. Open the pageInfo window.
3. Close the pageInfo window.

Reason: The observer doesn't get added on pages with no images. So there might not be an observer to remove on exit.

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060507 Minefield/3.0pre] (nightly) (W2Ksp4)

No bug, as the Media tab is not shown in this case.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

{{
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://navigator/content/pageinfo/pageInfo.js :: onUnloadPageInfo :: line 348"  data: no]
}}

Comment 2

[Serge Gautherie (:sgautherie)]

<http://mxr.mozilla.org/seamonkey/find?text=&kind=text&string=%2Fpageinfo%2Fpageinfo.>

Do we want to simply use |if (gImageView.data.length == 1) {| ?
Or to port the |mediaTab.hidden| behavior ?

Maybe even port bug 388504 ?

Comment 3

[[e-mail]]

(In reply to comment #2)
> Do we want to simply use |if (gImageView.data.length == 1) {| ?
Sounds good to me.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <pageInfo.js> [Checkin: Comment 15]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

*Added test.
*Added comments.
*Trivial rewrite.
*Added blank lines.

Comment 5

[Philip Chee]

> *Added blank lines.

Um any particular reason for the extra blank lines? Just asking.

Comment 6

[Philip Chee]

> *Added test.
I don't see anything added to the unit tests???

Comment 7

[[e-mail]]

Comment on attachment 324228 [details] [diff] [review]
(Av1) <pageInfo.js>
[Checkin: Comment 15]

We've been trying to keep the suite and browser versions roughly in sync so over to Daniel to see if he wants to port the other changes.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Um any particular reason for the extra blank lines? Just asking.

I find it easier to notice the |return|s...

(In reply to comment #6)
> I don't see anything added to the unit tests???

Bad wording: I meant the |if|.

Comment 9

[Philip Chee]

(In reply to comment #8)
>> Um any particular reason for the extra blank lines? Just asking.
> I find it easier to notice the |return|s...

General rule for mozilla.org patch submissions: don't alter whitespace in areas you aren't touching (unless it's a whitespace cleanup patch of course). This messes up CVS Blame. I've no idea if this still holds true for Hg/mozilla-central.

Comment 10

[Daniel Brooks [:db48x]]

Comment on attachment 324228 [details] [diff] [review]
(Av1) <pageInfo.js>
[Checkin: Comment 15]

yes, we need to keep them as close to in sync as possible.

Comment 11

[[e-mail]]

Comment on attachment 324228 [details] [diff] [review]
(Av1) <pageInfo.js>
[Checkin: Comment 15]

by which my understanding is that he'd like a patch to port the other changes (e.g. removal of the "os" variable) to browser.

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-FF) <pageInfo.js> [Checkin: Comment 14]

Port Av1 patch to FF, per comment 11.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 324791 [details] [diff] [review]
(Bv1-FF) <pageInfo.js>
[Checkin: Comment 14]

"approval1.9.0.1=?":
Trivial sync with </suite/>, "no" code change.

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 324791 [details] [diff] [review]
(Bv1-FF) <pageInfo.js>
[Checkin: Comment 14]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/1237fb220e76

Comment 15

[Reed Loden [:reed]]

Av1:

Checking in suite/browser/pageinfo/pageInfo.js;
/cvsroot/mozilla/suite/browser/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.13; previous revision: 1.12
done

Comment 16

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071206 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4)

V.Fixed

*****

(In reply to comment #2)
> Maybe even port bug 388504 ?

I filed bug 444917.